You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/15 15:24:21 UTC

[GitHub] [spark] maropu commented on a change in pull request #28826: [SPARK-31988][SQL] Schema pruning may discard attribute metadata

maropu commented on a change in pull request #28826:
URL: https://github.com/apache/spark/pull/28826#discussion_r440256983



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SchemaPruning.scala
##########
@@ -120,7 +120,8 @@ object SchemaPruning {
   private def getRootFields(expr: Expression): Seq[RootField] = {

Review comment:
       How about `private` -> `private[expressions]` if there is no other way to add tests?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org