You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/10 15:57:21 UTC
[GitHub] [skywalking-eyes] kezhenxu94 opened a new pull request #69: feature: support saving dependencies' licenses
kezhenxu94 opened a new pull request #69:
URL: https://github.com/apache/skywalking-eyes/pull/69
This is a missing but important feature that helps to organize the distribution package especially in ASF projects, it resolves and saves all LICENSE files of the dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] zooltd commented on pull request #69: feature: support saving dependencies' licenses
Posted by GitBox <gi...@apache.org>.
zooltd commented on pull request #69:
URL: https://github.com/apache/skywalking-eyes/pull/69#issuecomment-917821597
> @zooltd will you be available to enhance this part?
Yep, glad to help.😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] kezhenxu94 commented on pull request #69: feature: support saving dependencies' licenses
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #69:
URL: https://github.com/apache/skywalking-eyes/pull/69#issuecomment-917820367
@zooltd will you be available to enhance this part?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] zooltd edited a comment on pull request #69: feature: support saving dependencies' licenses
Posted by GitBox <gi...@apache.org>.
zooltd edited a comment on pull request #69:
URL: https://github.com/apache/skywalking-eyes/pull/69#issuecomment-917817905
This feature attempts to write each pkg's license content to respective files. The license content is resolved by each resolver. However, the resolving behavior of each resolver is inconsistent. To be more specific, in `GoModResolver`, it always record a mod's complete license content, cuz it identifies the mod's license through this content. In `NpmResolver`, it may not record the license content because it identifies a pkg's license through the field in a pkg's `package.json` file in the first priority. In `MavenPomResolver`, it simply records the raw data of the license field in a `pom.xml` file as the license content. So here's the problem, the license content to be written may be an empty string or something irrelevant. Maybe we should standardize each resolver's behavior. If the `LicenseContent` field to be written is empty, then simply write a license template to the file according to the `LicenseSpdxID` field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] wu-sheng merged pull request #69: feature: support saving dependencies' licenses
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #69:
URL: https://github.com/apache/skywalking-eyes/pull/69
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] zooltd commented on pull request #69: feature: support saving dependencies' licenses
Posted by GitBox <gi...@apache.org>.
zooltd commented on pull request #69:
URL: https://github.com/apache/skywalking-eyes/pull/69#issuecomment-917817905
This feature attempts to write the each pkg's license content to respective files. The license content is resolved by each resolver. However, the resolving behavior of each resolver is inconsistent. To be more specific, in `GoModResolver`, it always record a mod's complete license content, cuz it identifies the mod's license through this content. In `NpmResolver`, it may not record the license content because it identifies a pkg's license through the field in a pkg's `package.json` file in the first priority. In `MavenPomResolver`, it simply records the raw data of the license field in a `pom.xml` file as the license content. So here's the problem, the license content to be written may be an empty string or something irrelevant. Maybe we should standardize each resolver's behavior. If the `LicenseContent` field to be written is empty, then simply write a license template to the file according to the `LicenseSpdxID` field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] kezhenxu94 commented on pull request #69: feature: support saving dependencies' licenses
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #69:
URL: https://github.com/apache/skywalking-eyes/pull/69#issuecomment-917820061
> This feature attempts to write each pkg's license content to respective files. The license content is resolved by each resolver. However, the resolving behavior of each resolver is inconsistent. To be more specific, in `GoModResolver`, it always record a mod's complete license content, cuz it identifies the mod's license through this content. In `NpmResolver`, it may not record the license content because it identifies a pkg's license through the field in a pkg's `package.json` file in the first priority. In `MavenPomResolver`, it simply records the raw data of the license field in a `pom.xml` file as the license content. So here's the problem, the license content to be written may be an empty string or something irrelevant. Maybe we should standardize each resolver's behavior. If the `LicenseContent` field to be written is empty, then simply write a license template to the file according to the `LicenseSpdxID` field.
Yes there are still some resolvers that don't record the content, some of them record a spdx id and some of them record the license URL, we should make sure the Content field really saves the content, we may add other Fields that can be empty, like URL...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org