[GitHub] [ignite] rkondakov commented on a change in pull request #7377: IGNITE-12602 Calcite integration. JDBC Thin driver support.

[GitBox <gi...@apache.org>]

rkondakov commented on a change in pull request #7377: IGNITE-12602 Calcite integration. JDBC Thin driver support.
URL: https://github.com/apache/ignite/pull/7377#discussion_r378220740
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/jdbc/JdbcRequestHandler.java
 ##########
 @@ -723,6 +745,21 @@ private JdbcResponse executeQuery(JdbcQueryExecuteRequest req) {
         }
     }
 
+    /** */
+    private List<FieldsQueryCursor<List<?>>> querySqlFields(SqlFieldsQueryEx qry, GridQueryCancel cancel) {
+        if (experimentalQueryEngine != null) {
+            try {
+                return experimentalQueryEngine.query(QueryContext.of(qry, cancel), qry.getSchema(), qry.getSql(), qry.getArgs());
+            }
+            catch (IgniteSQLException e) {
+                U.warn(log, "Failed to execute SQL query using experimental engine. [qry=" + qry + ']', e);
 
 Review comment:
   I think we should not write this warning to log for DDL/DML queries.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services