[GitHub] [cloudstack] anuragaw commented on a change in pull request #3494: Fix hardcoded max data volumes when VM has been created but not started before

[GitBox <gi...@apache.org>]

anuragaw commented on a change in pull request #3494: Fix hardcoded max data volumes when VM has been created but not started before
URL: https://github.com/apache/cloudstack/pull/3494#discussion_r303950761
 
 

 ##########
 File path: engine/schema/src/main/java/com/cloud/hypervisor/dao/HypervisorCapabilitiesDaoImpl.java
 ##########
 @@ -106,4 +107,16 @@ public Boolean isVmSnapshotEnabled(HypervisorType hypervisorType, String hypervi
         HypervisorCapabilitiesVO result = getCapabilities(hypervisorType, hypervisorVersion);
         return result.getVmSnapshotEnabled();
     }
+
+    @Override
+    public List<HypervisorType> getHypervisorsWithDefaultEntries() {
 
 Review comment:
   Is there a possibility of high frequency calls to this method? If so we can perhaps optimize query calls with some caching? If not LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services