[GitHub] [geode] dschneider-pivotal commented on a change in pull request #7358: GEODE-10010: Sample Redis ops per second during operations in test

[GitBox <gi...@apache.org>]

dschneider-pivotal commented on a change in pull request #7358:
URL: https://github.com/apache/geode/pull/7358#discussion_r806060692



##########
File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/statistics/RedisStats.java
##########
@@ -37,23 +38,29 @@
   private final AtomicLong keyspaceMisses = new AtomicLong();
   private final AtomicLong uniqueChannelSubscriptions = new AtomicLong();
   private final AtomicLong uniquePatternSubscriptions = new AtomicLong();
-  private final ScheduledExecutorService perSecondExecutor;
+
+  private final int rollingAverageSamplesPerSecond = 16;

Review comment:
       I think this is a traditional constant so it would have to name it with all caps and underscores. As I was reading the code and saw it used I would have liked to know it was a constant that could never change.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org