[PATCH] Trace Past URL From Peg Revision - rev 5

[Shlomi Fish <sh...@iglu.org.il>]

Here is the fifth revision (all previous ones were kept only in my computer) 
of the past url tracing functinality.

What this includes is :

1. Some code to implement the function in libsvn_fs.

2. Addition of the callback to svn_ra_plugin_t.

3. A wrapper for it in svn_ra_local (with a bug fixed.)

4. A client program for this callback used for tracing purposes only that 
implements a call of this sort.

5. A new test file for testing it - currently with one test. 

I'll write a log entry when I get to it, but this isn't ready yet.

I did not integrate clkao's and ghudson's commentary yet. I wonder if I should 
or if it's critical.

Regards,

	Shlomi Fish
-- 

---------------------------------------------------------------------
Shlomi Fish      shlomif@iglu.org.il
Homepage:        http://shlomif.il.eu.org/

Quidquid latine dictum sit, altum viditur.
        [Whatever is said in Latin sounds profound.]

Re: [PATCH] Trace Past URL From Peg Revision - rev 5

[Ben Collins-Sussman <su...@collab.net>]

On Fri, 2004-04-02 at 13:07, Shlomi Fish wrote:
> Here is a new revision:
> 
> http://shlomif.il.eu.org/svn-patches/peg-revision-patch-rev8.patch
> 
> Changes since last time:
> 
> 1. More tests added.
> 
> 2. Made the tests' interface more robust.
> 
> 3. The standalone command line client for the peg function can now open 
> http:// URLs. (albeit still segfaults afterwards because the handler in the
> vtable is not implemented.)

You still haven't written a log message.  This is the single biggest
obstacle preventing people from paying attention to the patch.  You said
you "didn't have time" to write one yesterday, yet you've spent time
since then adding more code instead (?)

Don't underestimate the importance of the log message, or the importance
of responding to feedback from other developers.  Participating in an
open-source project is more than just throwing patches over a wall. :-)




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org