You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "jagub zhang (JIRA)" <ji...@apache.org> on 2011/06/22 09:46:47 UTC

[jira] [Issue Comment Edited] (WW-3025) Parameters get lost when file upload over max size allowed

    [ https://issues.apache.org/jira/browse/WW-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053075#comment-13053075 ] 

jagub zhang edited comment on WW-3025 at 6/22/11 7:45 AM:
----------------------------------------------------------

I don't think it is a problem.
Struts has another setting for fileupload, "struts.multipart.maxSize" in struts.xml
If don't set it , the default value is 2097152 (2M).
It means size of any file over 2M, SizeLimitExceededException will happen.

add this line into struts.xml
<constant name="struts.multipart.maxSize" value="-1" />
commons-fileupload will not check the size of the file.

then add maximumSize parameter of the fileupload interceptor, just like Mr.Maurizio Cucchiara 's recommend.
It will continue parse next parameters.

      was (Author: jagub.zhang@gmail.com):
    I don't think it is a problem.
Struts has another setting for fileupload, "struts.multipart.maxSize" as struts.xml
If don't set it , the default value is 2097152 (2M).
It means size of any file over 2M, SizeLimitExceededException will happen.

add this line into struts.xml
<constant name="struts.multipart.maxSize" value="-1" />
commons-fileupload will not check the size of the file.

then add maximumSize parameter of the fileupload interceptor, just like Mr.Maurizio Cucchiara 's recommend.
It will continue parse next parameters.
  
> Parameters get lost when file upload over max size allowed
> ----------------------------------------------------------
>
>                 Key: WW-3025
>                 URL: https://issues.apache.org/jira/browse/WW-3025
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Interceptors
>    Affects Versions: 2.1.6
>         Environment: All
>            Reporter: Tom Nguyen
>             Fix For: 2.2.x, 2.3
>
>
> When the uploaded file gets rejected because it's content, size, or because of a general problem an Exception is thrown by the MultiPartRequest class. Exceptions are: InvalidContentTypeException, UnknownSizeException, SizeLimitExceededException, and FileUploadException. This can lead to serious problems within the application because the other parameters from the upload form get lost. Happening in a profile page for example means that the user data is lost this can lead to a security Exception. In other case this usually just involves a OGNL-Exception. Meaning your field data like personal file name is lost. Workaround found in http://henning.kropponline.de/index.php/2009/01/18/struts2-fileuploadbase-exception/, but the the still keep uploading to server, not secured.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira