[GitHub] [maven-archetype] newur commented on a change in pull request #35: [ARCHETYPE-584] fix indentation in root pom.xml

[GitBox <gi...@apache.org>]

newur commented on a change in pull request #35:
URL: https://github.com/apache/maven-archetype/pull/35#discussion_r663358331



##########
File path: archetype-common/src/main/java/org/apache/maven/archetype/common/util/PomUtils.java
##########
@@ -79,6 +83,13 @@ public static boolean addNewModule( String artifactId, Reader fileReader, Writer
         dbf.setXIncludeAware( false );
         dbf.setExpandEntityReferences( false );
 
+        InputStream inputStream = PomUtils.class.getClassLoader().getResourceAsStream( "maven-4.0.0.xsd" );

Review comment:
       Please see my minimal, reproducible example here https://issues.apache.org/jira/browse/ARCHETYPE-584?focusedCommentId=17008264&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17008264
   
   I investigated this 1.5 years ago and can not remember the details why it only worked this way. However, I am pretty sure that I did not dive into the implementation details of `DocumentBuilderFactory`, which is fed with the `schema`, so not sure if I would have been able to explain it very deep back then.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org