You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Alexandra Sava <al...@gmail.com> on 2014/06/18 17:00:37 UTC

Review Request 22737: Test to check if the shutdown mechanism of the slave via SIGUSR1 signal is working properly

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22737/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Repository: mesos-git


Description
-------

Test to check the SIGUSR1 signal is properly delivered to the slave. The slave should then shutdown.


Diffs
-----

  src/tests/slave_recovery_tests.cpp 9a73348abefe7aad4a64d4911836b6eba682a7ca 

Diff: https://reviews.apache.org/r/22737/diff/


Testing
-------


Thanks,

Alexandra Sava


Re: Review Request 22737: Test to check if the shutdown mechanism of the slave via SIGUSR1 signal is working properly

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22737/#review46182
-----------------------------------------------------------

Ship it!


- Ben Mahler


On June 19, 2014, 12:41 a.m., Alexandra Sava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22737/
> -----------------------------------------------------------
> 
> (Updated June 19, 2014, 12:41 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Test to check the SIGUSR1 signal is properly delivered to the slave. The slave should then shutdown.
> 
> NOTE: this review relies on the following review: https://reviews.apache.org/r/21379/ 
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_recovery_tests.cpp 9a73348abefe7aad4a64d4911836b6eba682a7ca 
> 
> Diff: https://reviews.apache.org/r/22737/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexandra Sava
> 
>


Re: Review Request 22737: Test to check if the shutdown mechanism of the slave via SIGUSR1 signal is working properly

Posted by Alexandra Sava <al...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22737/
-----------------------------------------------------------

(Updated June 19, 2014, 12:41 a.m.)


Review request for mesos and Ben Mahler.


Changes
-------

Adding the dependent review. --bmahler


Repository: mesos-git


Description
-------

Test to check the SIGUSR1 signal is properly delivered to the slave. The slave should then shutdown.

NOTE: this review relies on the following review: https://reviews.apache.org/r/21379/ 


Diffs
-----

  src/tests/slave_recovery_tests.cpp 9a73348abefe7aad4a64d4911836b6eba682a7ca 

Diff: https://reviews.apache.org/r/22737/diff/


Testing
-------


Thanks,

Alexandra Sava


Re: Review Request 22737: Test to check if the shutdown mechanism of the slave via SIGUSR1 signal is working properly

Posted by Alexandra Sava <al...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22737/
-----------------------------------------------------------

(Updated June 18, 2014, 3:32 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos-git


Description
-------

Test to check the SIGUSR1 signal is properly delivered to the slave. The slave should then shutdown.

NOTE: this review relies on the following review: https://reviews.apache.org/r/21379/ 


Diffs
-----

  src/tests/slave_recovery_tests.cpp 9a73348abefe7aad4a64d4911836b6eba682a7ca 

Diff: https://reviews.apache.org/r/22737/diff/


Testing
-------


Thanks,

Alexandra Sava


Re: Review Request 22737: Test to check if the shutdown mechanism of the slave via SIGUSR1 signal is working properly

Posted by Alexandra Sava <al...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22737/
-----------------------------------------------------------

(Updated June 18, 2014, 3:31 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos-git


Description (updated)
-------

Test to check the SIGUSR1 signal is properly delivered to the slave. The slave should then shutdown.

NOTE: this review relies on the following review: https://reviews.apache.org/r/21379/ 


Diffs
-----

  src/tests/slave_recovery_tests.cpp 9a73348abefe7aad4a64d4911836b6eba682a7ca 

Diff: https://reviews.apache.org/r/22737/diff/


Testing
-------


Thanks,

Alexandra Sava