You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/29 03:17:55 UTC

[GitHub] [arrow] Dandandan commented on pull request #9038: ARROW-10356: [Rust][DataFusion] Add support for is_in (WIP)

Dandandan commented on pull request #9038:
URL: https://github.com/apache/arrow/pull/9038#issuecomment-751931814


   I think this is a great start @seddonm1 !
   
   Just some thoughts: an "ideal" implementation would convert the items upfront to an `Vec<i64>`, `Vec<String>`, etc on creation, so less work would be needed when executing the plan. Also, at some threshold for bigger arrays we could create a `HashSet<i64>`, `HashSet<String>` etc instead and write a kernel using a this HashSet.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org