You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Jakob Homan (JIRA)" <ji...@apache.org> on 2009/10/27 23:48:59 UTC
[jira] Created: (HADOOP-6337) Update FilterInitializer class to be
more visible and take a conf for further development
Update FilterInitializer class to be more visible and take a conf for further development
-----------------------------------------------------------------------------------------
Key: HADOOP-6337
URL: https://issues.apache.org/jira/browse/HADOOP-6337
Project: Hadoop Common
Issue Type: New Feature
Reporter: Jakob Homan
Assignee: Jakob Homan
Fix For: 0.22.0
Currently the FilterInitializer class, used to filter access to the Hadoop web interfaces, has its main method, initFilter, set to package private. This means that any classes wishing to implement this type must be in the same package. This should be public so FilterInitializers can reside in other packages.
Also, currently all parameters to the FilterInitializer must be provided at compile time (or via a different configuration method). It would be better if the FilterInitalizer::initFilter received a Configuration parameter so it can pull conf values out at run-time. Alternatively, the class could implement Configured, but that seems heavier than is needed at this point.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6337) Update FilterInitializer class to be
more visible and take a conf for further development
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-6337:
--------------------------------
Attachment: HADOOP-6337-Y.patch
Attaching patch for Y! 20 distribution.
> Update FilterInitializer class to be more visible and take a conf for further development
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-6337
> URL: https://issues.apache.org/jira/browse/HADOOP-6337
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.22.0
>
> Attachments: HADOOP-6337-Y.patch, HADOOP-6337.patch
>
>
> Currently the FilterInitializer class, used to filter access to the Hadoop web interfaces, has its main method, initFilter, set to package private. This means that any classes wishing to implement this type must be in the same package. This should be public so FilterInitializers can reside in other packages.
> Also, currently all parameters to the FilterInitializer must be provided at compile time (or via a different configuration method). It would be better if the FilterInitalizer::initFilter received a Configuration parameter so it can pull conf values out at run-time. Alternatively, the class could implement Configured, but that seems heavier than is needed at this point.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6337) Update FilterInitializer class to be
more visible and take a conf for further development
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-6337:
--------------------------------
Attachment: HADOOP-6337-Y.patch
Updated patch for Y! version, previous was missing a public declaration.
> Update FilterInitializer class to be more visible and take a conf for further development
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-6337
> URL: https://issues.apache.org/jira/browse/HADOOP-6337
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.22.0
>
> Attachments: HADOOP-6337-Y.patch, HADOOP-6337.patch
>
>
> Currently the FilterInitializer class, used to filter access to the Hadoop web interfaces, has its main method, initFilter, set to package private. This means that any classes wishing to implement this type must be in the same package. This should be public so FilterInitializers can reside in other packages.
> Also, currently all parameters to the FilterInitializer must be provided at compile time (or via a different configuration method). It would be better if the FilterInitalizer::initFilter received a Configuration parameter so it can pull conf values out at run-time. Alternatively, the class could implement Configured, but that seems heavier than is needed at this point.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6337) Update FilterInitializer class to
be more visible and take a conf for further development
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770718#action_12770718 ]
Hadoop QA commented on HADOOP-6337:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12423376/HADOOP-6337.patch
against trunk revision 829289.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/107/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/107/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/107/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/107/console
This message is automatically generated.
> Update FilterInitializer class to be more visible and take a conf for further development
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-6337
> URL: https://issues.apache.org/jira/browse/HADOOP-6337
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.22.0
>
> Attachments: HADOOP-6337.patch
>
>
> Currently the FilterInitializer class, used to filter access to the Hadoop web interfaces, has its main method, initFilter, set to package private. This means that any classes wishing to implement this type must be in the same package. This should be public so FilterInitializers can reside in other packages.
> Also, currently all parameters to the FilterInitializer must be provided at compile time (or via a different configuration method). It would be better if the FilterInitalizer::initFilter received a Configuration parameter so it can pull conf values out at run-time. Alternatively, the class could implement Configured, but that seems heavier than is needed at this point.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6337) Update FilterInitializer class to be
more visible and take a conf for further development
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-6337:
--------------------------------
Attachment: HADOOP-6337.patch
Patch with changes:
* Update FilterInitializer class
* Update test cases that test FilterInitializer
* Update where filters are initialized in http server.
No new tests as very difficult to test these changes. Manually verified that can now create a FilterInitializer in another package and that the new param is seen.
> Update FilterInitializer class to be more visible and take a conf for further development
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-6337
> URL: https://issues.apache.org/jira/browse/HADOOP-6337
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.22.0
>
> Attachments: HADOOP-6337.patch
>
>
> Currently the FilterInitializer class, used to filter access to the Hadoop web interfaces, has its main method, initFilter, set to package private. This means that any classes wishing to implement this type must be in the same package. This should be public so FilterInitializers can reside in other packages.
> Also, currently all parameters to the FilterInitializer must be provided at compile time (or via a different configuration method). It would be better if the FilterInitalizer::initFilter received a Configuration parameter so it can pull conf values out at run-time. Alternatively, the class could implement Configured, but that seems heavier than is needed at this point.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6337) Update FilterInitializer class to be
more visible and take a conf for further development
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-6337:
-------------------------------------------
Hadoop Flags: [Reviewed]
+1 patch looks good.
> Update FilterInitializer class to be more visible and take a conf for further development
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-6337
> URL: https://issues.apache.org/jira/browse/HADOOP-6337
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.22.0
>
> Attachments: HADOOP-6337.patch
>
>
> Currently the FilterInitializer class, used to filter access to the Hadoop web interfaces, has its main method, initFilter, set to package private. This means that any classes wishing to implement this type must be in the same package. This should be public so FilterInitializers can reside in other packages.
> Also, currently all parameters to the FilterInitializer must be provided at compile time (or via a different configuration method). It would be better if the FilterInitalizer::initFilter received a Configuration parameter so it can pull conf values out at run-time. Alternatively, the class could implement Configured, but that seems heavier than is needed at this point.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6337) Update FilterInitializer class to be
more visible and take a conf for further development
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-6337:
--------------------------------
Status: Patch Available (was: Open)
submitting patch
> Update FilterInitializer class to be more visible and take a conf for further development
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-6337
> URL: https://issues.apache.org/jira/browse/HADOOP-6337
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.22.0
>
> Attachments: HADOOP-6337.patch
>
>
> Currently the FilterInitializer class, used to filter access to the Hadoop web interfaces, has its main method, initFilter, set to package private. This means that any classes wishing to implement this type must be in the same package. This should be public so FilterInitializers can reside in other packages.
> Also, currently all parameters to the FilterInitializer must be provided at compile time (or via a different configuration method). It would be better if the FilterInitalizer::initFilter received a Configuration parameter so it can pull conf values out at run-time. Alternatively, the class could implement Configured, but that seems heavier than is needed at this point.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6337) Update FilterInitializer class to
be more visible and take a conf for further development
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770690#action_12770690 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-6337:
------------------------------------------------
+1 the proposal sounds good.
> Update FilterInitializer class to be more visible and take a conf for further development
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-6337
> URL: https://issues.apache.org/jira/browse/HADOOP-6337
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.22.0
>
>
> Currently the FilterInitializer class, used to filter access to the Hadoop web interfaces, has its main method, initFilter, set to package private. This means that any classes wishing to implement this type must be in the same package. This should be public so FilterInitializers can reside in other packages.
> Also, currently all parameters to the FilterInitializer must be provided at compile time (or via a different configuration method). It would be better if the FilterInitalizer::initFilter received a Configuration parameter so it can pull conf values out at run-time. Alternatively, the class could implement Configured, but that seems heavier than is needed at this point.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6337) Update FilterInitializer class to
be more visible and take a conf for further development
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774587#action_12774587 ]
Hudson commented on HADOOP-6337:
--------------------------------
Integrated in Hadoop-Common-trunk #151 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/151/])
. Updates FilterInitializer class to be more visible, and the init of the class is made to take a Configuration argument. Contributed by Jakob Homan.
> Update FilterInitializer class to be more visible and take a conf for further development
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-6337
> URL: https://issues.apache.org/jira/browse/HADOOP-6337
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.22.0
>
> Attachments: HADOOP-6337.patch
>
>
> Currently the FilterInitializer class, used to filter access to the Hadoop web interfaces, has its main method, initFilter, set to package private. This means that any classes wishing to implement this type must be in the same package. This should be public so FilterInitializers can reside in other packages.
> Also, currently all parameters to the FilterInitializer must be provided at compile time (or via a different configuration method). It would be better if the FilterInitalizer::initFilter received a Configuration parameter so it can pull conf values out at run-time. Alternatively, the class could implement Configured, but that seems heavier than is needed at this point.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6337) Update FilterInitializer class to be
more visible and take a conf for further development
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-6337:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Jakob!
> Update FilterInitializer class to be more visible and take a conf for further development
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-6337
> URL: https://issues.apache.org/jira/browse/HADOOP-6337
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.22.0
>
> Attachments: HADOOP-6337.patch
>
>
> Currently the FilterInitializer class, used to filter access to the Hadoop web interfaces, has its main method, initFilter, set to package private. This means that any classes wishing to implement this type must be in the same package. This should be public so FilterInitializers can reside in other packages.
> Also, currently all parameters to the FilterInitializer must be provided at compile time (or via a different configuration method). It would be better if the FilterInitalizer::initFilter received a Configuration parameter so it can pull conf values out at run-time. Alternatively, the class could implement Configured, but that seems heavier than is needed at this point.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6337) Update FilterInitializer class to be
more visible and take a conf for further development
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-6337:
--------------------------------
Attachment: (was: HADOOP-6337-Y.patch)
> Update FilterInitializer class to be more visible and take a conf for further development
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-6337
> URL: https://issues.apache.org/jira/browse/HADOOP-6337
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.22.0
>
> Attachments: HADOOP-6337-Y.patch, HADOOP-6337.patch
>
>
> Currently the FilterInitializer class, used to filter access to the Hadoop web interfaces, has its main method, initFilter, set to package private. This means that any classes wishing to implement this type must be in the same package. This should be public so FilterInitializers can reside in other packages.
> Also, currently all parameters to the FilterInitializer must be provided at compile time (or via a different configuration method). It would be better if the FilterInitalizer::initFilter received a Configuration parameter so it can pull conf values out at run-time. Alternatively, the class could implement Configured, but that seems heavier than is needed at this point.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.