You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/14 07:31:25 UTC
[GitHub] [airflow] linchun3 commented on pull request #16160: Fix: GCS To BigQuery source_object
linchun3 commented on pull request #16160:
URL: https://github.com/apache/airflow/pull/16160#issuecomment-943090621
hey, @tegardp I noticed that this change could be missing an edge case when retrieving a list of files from `x_com`:
Example:
```
default_args = {
"render_template_as_native_obj": True
}
...
# retrieval of files from x_com
files = ["file1.txt", "file2.txt", "file3.txt"]
```
since the rendering to native object only happens on `execute`, the value retrieve from x_comms would still be
`"["file1.txt", "file2.txt", "file3.txt"]"` on initialisation and `self.source_objects` of the operator would be `["["file1.txt", "file2.txt", "file3.txt"]"]` which is not the intended behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org