You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/10/04 19:05:03 UTC

[GitHub] codecov-io commented on issue #6034: [Dashboard] disable force refresh when chart is still loading

codecov-io commented on issue #6034: [Dashboard] disable force refresh when chart is still loading
URL: https://github.com/apache/incubator-superset/pull/6034#issuecomment-427134195
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6034?src=pr&el=h1) Report
   > Merging [#6034](https://codecov.io/gh/apache/incubator-superset/pull/6034?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e12d00ae717534a442a12aee1e9f8151d9563242?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `40%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/6034/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/6034?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6034      +/-   ##
   ==========================================
   + Coverage   64.63%   64.64%   +<.01%     
   ==========================================
     Files         449      450       +1     
     Lines       23823    23829       +6     
     Branches     2639     2642       +3     
   ==========================================
   + Hits        15398    15404       +6     
     Misses       8412     8412              
     Partials       13       13
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/6034?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6034/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXJBY3Rpb25zRHJvcGRvd24uanN4) | `81.25% <ø> (ø)` | :arrow_up: |
   | [superset/assets/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/6034/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9jaGFydFJlZHVjZXIuanM=) | `16.94% <ø> (ø)` | :arrow_up: |
   | [...set/assets/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/6034/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3JlZHVjZXJzL2dldEluaXRpYWxTdGF0ZS5qcw==) | `93.33% <ø> (-0.42%)` | :arrow_down: |
   | [...uperset/assets/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6034/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXIuanN4) | `57.29% <0%> (-1.22%)` | :arrow_down: |
   | [...s/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6034/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9TbGljZUhlYWRlckNvbnRyb2xzLmpzeA==) | `36.53% <0%> (-0.72%)` | :arrow_down: |
   | [...et/assets/src/dashboard/util/isDashboardLoading.js](https://codecov.io/gh/apache/incubator-superset/pull/6034/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9pc0Rhc2hib2FyZExvYWRpbmcuanM=) | `100% <100%> (ø)` | |
   | [...ssets/src/dashboard/containers/DashboardHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6034/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29udGFpbmVycy9EYXNoYm9hcmRIZWFkZXIuanN4) | `100% <100%> (ø)` | :arrow_up: |
   | [superset/dashboard\_import\_export\_util.py](https://codecov.io/gh/apache/incubator-superset/pull/6034/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnRfdXRpbC5weQ==) | `40.74% <0%> (-25.93%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/6034/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `81.13% <0%> (+0.75%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/incubator-superset/pull/6034/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6034?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6034?src=pr&el=footer). Last update [e12d00a...9f1c9c7](https://codecov.io/gh/apache/incubator-superset/pull/6034?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org