You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by StyleTang <gi...@git.apache.org> on 2017/05/13 02:53:10 UTC

[GitHub] incubator-rocketmq pull request #103: [ROCKETMQ-198]add LanguageCode for GO ...

GitHub user StyleTang opened a pull request:

    https://github.com/apache/incubator-rocketmq/pull/103

    [ROCKETMQ-198]add LanguageCode for GO and PHP

    https://issues.apache.org/jira/browse/ROCKETMQ-198
    LanguageCode without GO. The language can only use OTHER
    ![go-client-consumer-detail](https://raw.githubusercontent.com/StyleTang/self-test/master/pic/go-client-consumer-detail.png)
    [Go-Client's implement](https://github.com/apache/incubator-rocketmq-externals/pull/22)
    [Go-Client's design](https://github.com/apache/incubator-rocketmq-externals/pull/19)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StyleTang/incubator-rocketmq master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rocketmq/pull/103.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #103
    
----
commit dea7f85d6bcd55e941aa8831128e901e2db2f1e0
Author: tangjie <st...@gmail.com>
Date:   2017-05-13T02:38:11Z

    add LanguageCode for GO and PHP

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #103: [ROCKETMQ-198]add LanguageCode for GO ...

Posted by StyleTang <gi...@git.apache.org>.
GitHub user StyleTang reopened a pull request:

    https://github.com/apache/incubator-rocketmq/pull/103

    [ROCKETMQ-198]add LanguageCode for GO and PHP

    https://issues.apache.org/jira/browse/ROCKETMQ-198
    LanguageCode without GO. The language can only use OTHER
    ![go-client-consumer-detail](https://raw.githubusercontent.com/StyleTang/self-test/master/pic/go-client-consumer-detail-new.png)
    [Go-Client's implement](https://github.com/apache/incubator-rocketmq-externals/pull/22)
    [Go-Client's design](https://github.com/apache/incubator-rocketmq-externals/pull/19)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StyleTang/incubator-rocketmq master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rocketmq/pull/103.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #103
    
----
commit dea7f85d6bcd55e941aa8831128e901e2db2f1e0
Author: tangjie <st...@gmail.com>
Date:   2017-05-13T02:38:11Z

    add LanguageCode for GO and PHP

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #103: [ROCKETMQ-198]add LanguageCode for GO and PHP

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/103
  
    
    [![Coverage Status](https://coveralls.io/builds/11504690/badge)](https://coveralls.io/builds/11504690)
    
    Coverage increased (+0.002%) to 30.979% when pulling **dea7f85d6bcd55e941aa8831128e901e2db2f1e0 on StyleTang:master** into **fa85abcdf6ee46e56403ddf86828a38683103fd0 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #103: [ROCKETMQ-198]add LanguageCode for GO ...

Posted by StyleTang <gi...@git.apache.org>.
Github user StyleTang closed the pull request at:

    https://github.com/apache/incubator-rocketmq/pull/103


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #103: [ROCKETMQ-198]add LanguageCode for GO and PHP

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/103
  
    
    [![Coverage Status](https://coveralls.io/builds/12794894/badge)](https://coveralls.io/builds/12794894)
    
    Coverage increased (+7.8%) to 38.816% when pulling **dea7f85d6bcd55e941aa8831128e901e2db2f1e0 on StyleTang:master** into **fa85abcdf6ee46e56403ddf86828a38683103fd0 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #103: [ROCKETMQ-198]add LanguageCode for GO and PHP

Posted by Jaskey <gi...@git.apache.org>.
Github user Jaskey commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/103
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #103: [ROCKETMQ-198]add LanguageCode for GO and PHP

Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/103
  
    @StyleTang  Merged, please close this issue at your earliest convenient time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #103: [ROCKETMQ-198]add LanguageCode for GO and PHP

Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/103
  
    +1
    
    Considering this is a trivial change and unlikely to introduce any risk, I'll merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #103: [ROCKETMQ-198]add LanguageCode for GO and PHP

Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/103
  
    @lizhanhui It seems that this PR had not been merged. I will handle this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #103: [ROCKETMQ-198]add LanguageCode for GO and PHP

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/103
  
    
    [![Coverage Status](https://coveralls.io/builds/12794894/badge)](https://coveralls.io/builds/12794894)
    
    Coverage increased (+7.8%) to 38.816% when pulling **dea7f85d6bcd55e941aa8831128e901e2db2f1e0 on StyleTang:master** into **fa85abcdf6ee46e56403ddf86828a38683103fd0 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #103: [ROCKETMQ-198]add LanguageCode for GO ...

Posted by StyleTang <gi...@git.apache.org>.
Github user StyleTang closed the pull request at:

    https://github.com/apache/incubator-rocketmq/pull/103


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---