You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/26 03:00:54 UTC
[GitHub] [doris] ByteYue opened a new pull request, #13671: [BugFix](function) fix reverse function dynamic buffer overflow due to illegal character
ByteYue opened a new pull request, #13671:
URL: https://github.com/apache/doris/pull/13671
# Proposed changes
Previous logic of reverse function might not be strong enough to handle illegal character. For example, one one byte size character would be mistaken as one utf-8 character which occupies more than one byte space. And unfortunately exceeding the buffer space during future process.
Issue Number: close #xxx
## Problem summary
Truncate the copy process when detecting overflow memory accessing.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [x] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [x] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13671: [BugFix](function) fix reverse function dynamic buffer overflow due to illegal character
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13671:
URL: https://github.com/apache/doris/pull/13671#issuecomment-1291654583
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #13671: [BugFix](function) fix reverse function dynamic buffer overflow due to illegal character
Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #13671:
URL: https://github.com/apache/doris/pull/13671#discussion_r1005275348
##########
be/src/util/simd/vstring_function.h:
##########
@@ -150,7 +151,11 @@ class VStringFunctions {
} else {
for (size_t i = 0, char_size = 0; i < str.len; i += char_size) {
char_size = get_utf8_byte_length((unsigned)(str.ptr)[i]);
- std::copy(str.ptr + i, str.ptr + i + char_size, dst.ptr + str.len - i - char_size);
+ size_t offset = i + char_size;
Review Comment:
Please add comment for the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13671: [BugFix](function) fix reverse function dynamic buffer overflow due to illegal character
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13671:
URL: https://github.com/apache/doris/pull/13671#issuecomment-1293322389
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.12 seconds
load time: 568 seconds
storage size: 17154644849 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221027183037_clickbench_pr_34737.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #13671: [BugFix](function) fix reverse function dynamic buffer overflow due to illegal character
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #13671:
URL: https://github.com/apache/doris/pull/13671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13671: [BugFix](function) fix reverse function dynamic buffer overflow due to illegal character
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13671:
URL: https://github.com/apache/doris/pull/13671#issuecomment-1291654651
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org