You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/03/31 11:11:37 UTC

[GitHub] [arrow-rs] tustvold opened a new pull request, #3987: Revert workspace links for object_store

tustvold opened a new pull request, #3987:
URL: https://github.com/apache/arrow-rs/pull/3987

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   # Rationale for this change
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   These cause the verification scripts for the release tarballs to fails, as the workspace is stripped out.
   
   Longer-term we probably need to work out a better solution to this, perhaps as part of #3414, but this quick fix works for now
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on pull request #3987: Revert workspace links for object_store

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #3987:
URL: https://github.com/apache/arrow-rs/pull/3987#issuecomment-1491762454

   I'm going to get this in as it should be non-controversial and is blocking the release


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3987: Revert workspace links for object_store

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #3987:
URL: https://github.com/apache/arrow-rs/pull/3987#discussion_r1154346839


##########
object_store/Cargo.toml:
##########
@@ -18,12 +18,12 @@
 [package]
 name = "object_store"
 version = "0.5.6"
-edition = { workspace = true }
+edition = "2021"
 license = "MIT/Apache-2.0"
 readme = "README.md"
 description = "A generic object store interface for uniformly interacting with AWS S3, Google Cloud Storage, Azure Blob Storage and local files."
 keywords = ["object", "storage", "cloud"]
-repository = { workspace = true }
+repository = "https://github.com/apache/arrow-rs/tree/master/object_store"

Review Comment:
   I took the opportunity to make the repository URL actually point to the object_store directory



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold merged pull request #3987: Revert workspace links for object_store

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #3987:
URL: https://github.com/apache/arrow-rs/pull/3987


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org