[jira] [Commented] (YARN-2328) FairScheduler: Verify update and continuous scheduling threads are stopped when the scheduler is stopped

["Sandy Ryza (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14071361#comment-14071361 ] 

Sandy Ryza commented on YARN-2328:
----------------------------------

{code}
-        if (node != null && Resources.fitsIn(minimumAllocation,
-            node.getAvailableResource())) {
+        if (node != null &&
+            Resources.fitsIn(minimumAllocation, node.getAvailableResource())) {
{code}
This looks unrelated.

+1 otherwise.

> FairScheduler: Verify update and continuous scheduling threads are stopped when the scheduler is stopped
> --------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2328
>                 URL: https://issues.apache.org/jira/browse/YARN-2328
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.4.1
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>            Priority: Minor
>         Attachments: yarn-2328-1.patch
>
>
> FairScheduler threads can use a little cleanup and tests. To begin with, the update and continuous-scheduling threads should extend Thread and handle being interrupted. We should have tests for starting and stopping them as well. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)