You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/16 15:08:51 UTC
[GitHub] [spark] srowen commented on a change in pull request #30784: [SPARK-33560][test-maven][BUILD] Add "unused-import" check to Maven compilation process
srowen commented on a change in pull request #30784:
URL: https://github.com/apache/spark/pull/30784#discussion_r544374716
##########
File path: pom.xml
##########
@@ -3220,9 +3217,33 @@
<profile>
<id>scala-2.12</id>
+ <activation>
Review comment:
This might be problematic - yes it should be the default, but this doesn't activate if any other profiles are activated, which may be surprising. What happens if neither is specified?
Generally the "2.12" configuration goes in the main POM and then is overridden for non-default profiles here. So if 2.13 needs different config, that's fine, but 2.12's config should be up top. If the problem is _overwriting_ Maven config in a profile, I can show you how to do that.
##########
File path: pom.xml
##########
@@ -2503,9 +2503,6 @@
<recompileMode>incremental</recompileMode>
<useZincServer>true</useZincServer>
<args>
- <arg>-unchecked</arg>
Review comment:
Oh yeah, I recall this one has been around forever. But I'm pretty sure another change fixed something just like this by, well, just removing that dangling statement, which doesn't seem to do what it means to anyway. Maybe just fix that here directly rather than remove it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org