[GitHub] [airflow] jedcunningham commented on a diff in pull request #25732: Adding podAnnotations to StatsD deployment template

[GitBox <gi...@apache.org>]

jedcunningham commented on code in PR #25732:
URL: https://github.com/apache/airflow/pull/25732#discussion_r970237820


##########
chart/templates/statsd/statsd-deployment.yaml:
##########
@@ -57,9 +57,17 @@ spec:
 {{- with .Values.labels }}
 {{ toYaml . | indent 8 }}
 {{- end }}
-{{- if .Values.statsd.extraMappings }}
+{{- if or .Values.statsd.extraMappings .Values.airflowPodAnnotations .Values.statsd.podAnnotations }}

Review Comment:
   ```suggestion
   {{- if or .Values.statsd.extraMappings .Values.statsd.podAnnotations }}
   ```
   
   Let's not include the `airflowPodAnnotations`. This isn't an Airflow pod.



##########
chart/templates/statsd/statsd-deployment.yaml:
##########
@@ -57,9 +57,17 @@ spec:
 {{- with .Values.labels }}
 {{ toYaml . | indent 8 }}
 {{- end }}
-{{- if .Values.statsd.extraMappings }}
+{{- if or .Values.statsd.extraMappings .Values.airflowPodAnnotations .Values.statsd.podAnnotations }}
       annotations:
+        {{- if .Values.statsd.extraMappings }}
         checksum/statsd-config: {{ include (print $.Template.BasePath "/configmaps/statsd-configmap.yaml") . | sha256sum }}
+        {{- end }}
+        {{- if .Values.airflowPodAnnotations }}
+        {{- toYaml .Values.airflowPodAnnotations | nindent 8 }}
+        {{- end }}

Review Comment:
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org