You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "creaiter (via GitHub)" <gi...@apache.org> on 2024/01/24 10:48:35 UTC

[PR] [Unity][Cutlass] Fix C source generation of dense operation [tvm]

creaiter opened a new pull request, #16463:
URL: https://github.com/apache/tvm/pull/16463

   It seems there are two issues while generating c source of dense operation using cutlass.
   
   1. Even though the dense operation contains bias parameters, the generated c code doesn't reflect that bias correctly.
   2. The weight shape of dense operation looks flipped for the 1st and 2nd dimensions.
   
   I tried to fix above bugs. Please check that and leave feedback.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Unity][Cutlass] Fix C source generation of dense operation [tvm]

Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi commented on PR #16463:
URL: https://github.com/apache/tvm/pull/16463#issuecomment-1908867323

   You can now send a PR to the `main`. Can you switch a branch or reopen?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Unity][Cutlass] Fix C source generation of dense operation [tvm]

Posted by "creaiter (via GitHub)" <gi...@apache.org>.
creaiter closed pull request #16463: [Unity][Cutlass] Fix C source generation of dense operation
URL: https://github.com/apache/tvm/pull/16463


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Unity][Cutlass] Fix C source generation of dense operation [tvm]

Posted by "creaiter (via GitHub)" <gi...@apache.org>.
creaiter commented on PR #16463:
URL: https://github.com/apache/tvm/pull/16463#issuecomment-1911649513

   Okay! I'm going to reopen this PR to the `main`.
   
   I noticed that the second issue already resolved, thus the reopened PR will only contain the change of the first issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org