You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/01 23:31:58 UTC
[GitHub] [spark] Jeffreychen99 opened a new pull request, #37364: [SPARK-39936] Store schema in properties for Spark Views
Jeffreychen99 opened a new pull request, #37364:
URL: https://github.com/apache/spark/pull/37364
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Jeffreychen99 commented on a diff in pull request #37364: [SPARK-39936][SQL] Store schema in properties for Spark Views
Posted by GitBox <gi...@apache.org>.
Jeffreychen99 commented on code in PR #37364:
URL: https://github.com/apache/spark/pull/37364#discussion_r935031668
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala:
##########
@@ -2386,10 +2385,6 @@ class HiveDDLSuite
"CREATE TABLE t1 USING PARQUET AS SELECT NULL AS null_col",
"Parquet data source does not support void data type")
- assertAnalysisError(
Review Comment:
Oops - sorry forgot to add them back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #37364: [SPARK-39936][SQL] Store schema in properties for Spark Views
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #37364: [SPARK-39936][SQL] Store schema in properties for Spark Views
URL: https://github.com/apache/spark/pull/37364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #37364: [SPARK-39936] Store schema in properties for Spark Views
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #37364:
URL: https://github.com/apache/spark/pull/37364#discussion_r935010782
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveParquetSourceSuite.scala:
##########
@@ -378,4 +378,15 @@ class HiveParquetSourceSuite extends ParquetPartitioningTest with ParquetTest {
}
}
}
+
+ test("Create view with dashes in column type") {
+ sql(
+ """
+ |CREATE TABLE tbl (f array<struct<`date-of-creation`:string>>) USING parquet
+ |""".stripMargin)
+ sql(
+ """
+ |CREATE VIEW tblView AS SELECT f FROM tbl
Review Comment:
we can simply use the existing test case `CREATE VIEW t AS SELECT STRUCT('a' AS `$a`, 1 AS b) q`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #37364: [SPARK-39936] Store schema in properties for Spark Views
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #37364:
URL: https://github.com/apache/spark/pull/37364#discussion_r935010000
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala:
##########
@@ -283,7 +283,22 @@ private[spark] class HiveExternalCatalog(conf: SparkConf, hadoopConf: Configurat
// columns etc. in table properties, so that we can work around the Hive metastore issue
// about not case preserving and make Hive serde table and view support mixed-case column
// names.
- properties = tableDefinition.properties ++ tableMetaToTableProps(tableDefinition))
+ properties = tableDefinition.properties ++ tableMetaToTableProps(tableDefinition)
+ )
+ try {
+ client.createTable(tableWithDataSourceProps, ignoreIfExists)
+ } catch {
+ case NonFatal(e) =>
Review Comment:
```suggestion
case NonFatal(e) if ...is_view... =>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #37364: [SPARK-39936] Store schema in properties for Spark Views
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #37364:
URL: https://github.com/apache/spark/pull/37364#discussion_r935011158
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveParquetSourceSuite.scala:
##########
@@ -378,4 +378,15 @@ class HiveParquetSourceSuite extends ParquetPartitioningTest with ParquetTest {
}
}
}
+
+ test("Create view with dashes in column type") {
+ sql(
+ """
+ |CREATE TABLE tbl (f array<struct<`date-of-creation`:string>>) USING parquet
+ |""".stripMargin)
+ sql(
+ """
+ |CREATE VIEW tblView AS SELECT f FROM tbl
Review Comment:
and let's make the test complete
```
withView("t") {
sql("CREATE VIEW t AS SELECT STRUCT('a' AS $a, 1 AS b) q")
checkAnswer(spark.table("t"), Row(Row("a", 1)))
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #37364: [SPARK-39936] Store schema in properties for Spark Views
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #37364:
URL: https://github.com/apache/spark/pull/37364#discussion_r935010522
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala:
##########
@@ -160,18 +160,6 @@ class HiveCatalogedDDLSuite extends DDLSuite with TestHiveSingleton with BeforeA
}
test("SPARK-22431: illegal nested type") {
- val queries = Seq(
- "CREATE TABLE t USING hive AS SELECT STRUCT('a' AS `$a`, 1 AS b) q",
- "CREATE TABLE t(q STRUCT<`$a`:INT, col2:STRING>, i1 INT) USING hive",
- "CREATE VIEW t AS SELECT STRUCT('a' AS `$a`, 1 AS b) q")
Review Comment:
I think we only need to remove this line from the test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #37364: [SPARK-39936][SQL] Store schema in properties for Spark Views
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #37364:
URL: https://github.com/apache/spark/pull/37364#discussion_r935030049
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala:
##########
@@ -2386,10 +2385,6 @@ class HiveDDLSuite
"CREATE TABLE t1 USING PARQUET AS SELECT NULL AS null_col",
"Parquet data source does not support void data type")
- assertAnalysisError(
Review Comment:
do we still need to remove this test?
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala:
##########
@@ -2400,10 +2395,6 @@ class HiveDDLSuite
"CREATE TABLE t1 (v VOID) USING PARQUET",
"Parquet data source does not support void data type")
- assertAnalysisError(
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #37364: [SPARK-39936][SQL] Store schema in properties for Spark Views
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #37364:
URL: https://github.com/apache/spark/pull/37364#issuecomment-1204272227
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #37364: [SPARK-39936][SQL] Store schema in properties for Spark Views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #37364:
URL: https://github.com/apache/spark/pull/37364#issuecomment-1203205196
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37364: [SPARK-39936][SQL] Store schema in properties for Spark Views
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37364:
URL: https://github.com/apache/spark/pull/37364#issuecomment-1203959291
SparkR test is irrelevant. We can ignore that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #37364: [SPARK-39936] Store schema in properties for Spark Views
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #37364:
URL: https://github.com/apache/spark/pull/37364#discussion_r935010178
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala:
##########
@@ -283,7 +283,22 @@ private[spark] class HiveExternalCatalog(conf: SparkConf, hadoopConf: Configurat
// columns etc. in table properties, so that we can work around the Hive metastore issue
// about not case preserving and make Hive serde table and view support mixed-case column
// names.
- properties = tableDefinition.properties ++ tableMetaToTableProps(tableDefinition))
+ properties = tableDefinition.properties ++ tableMetaToTableProps(tableDefinition)
+ )
+ try {
+ client.createTable(tableWithDataSourceProps, ignoreIfExists)
+ } catch {
+ case NonFatal(e) =>
+ // If for some reason we fail to store the schema we store it as empty there
+ // since we already store the real schema in the table properties. This try-catch
+ // should only be necessary for Spark views which are incompatible with Hive
+ client.createTable(
+ tableWithDataSourceProps.copy(
+ schema = StructType(EMPTY_DATA_SCHEMA ++ tableDefinition.partitionSchema)
Review Comment:
A view cannot have partition columns, so here can simply be `new StructType()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org