You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@accumulo.apache.org by mw...@apache.org on 2019/01/07 19:21:15 UTC
[accumulo] branch master updated: Fix MapReduce bug (#874)
This is an automated email from the ASF dual-hosted git repository.
mwalch pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/accumulo.git
The following commit(s) were added to refs/heads/master by this push:
new 0adec43 Fix MapReduce bug (#874)
0adec43 is described below
commit 0adec43da0d3652f4642c5fbcd16537fccf4a0aa
Author: Mike Walch <mw...@apache.org>
AuthorDate: Mon Jan 7 14:21:11 2019 -0500
Fix MapReduce bug (#874)
* AccumuloOutputFormat is using wrong getClientInfo method
---
.../java/org/apache/accumulo/hadoop/mapred/AccumuloOutputFormat.java | 4 +---
.../org/apache/accumulo/hadoop/mapreduce/AccumuloOutputFormat.java | 4 +---
.../accumulo/hadoopImpl/mapreduce/AccumuloOutputFormatImpl.java | 2 +-
.../apache/accumulo/cluster/standalone/StandaloneClusterControl.java | 2 --
4 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoop/mapred/AccumuloOutputFormat.java b/hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoop/mapred/AccumuloOutputFormat.java
index f380c05..d29ed16 100644
--- a/hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoop/mapred/AccumuloOutputFormat.java
+++ b/hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoop/mapred/AccumuloOutputFormat.java
@@ -16,8 +16,6 @@
*/
package org.apache.accumulo.hadoop.mapred;
-import static org.apache.accumulo.hadoopImpl.mapred.AccumuloOutputFormatImpl.getClientInfo;
-
import java.io.IOException;
import org.apache.accumulo.core.client.Accumulo;
@@ -46,7 +44,7 @@ public class AccumuloOutputFormat implements OutputFormat<Text,Mutation> {
@Override
public void checkOutputSpecs(FileSystem ignored, JobConf job) throws IOException {
- ClientInfo clientInfo = getClientInfo(job);
+ ClientInfo clientInfo = AccumuloOutputFormatImpl.getClientInfo(job);
String principal = clientInfo.getPrincipal();
AuthenticationToken token = clientInfo.getAuthenticationToken();
try (AccumuloClient c = Accumulo.newClient().from(clientInfo.getProperties()).build()) {
diff --git a/hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoop/mapreduce/AccumuloOutputFormat.java b/hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoop/mapreduce/AccumuloOutputFormat.java
index 601b671..a33e93f 100644
--- a/hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoop/mapreduce/AccumuloOutputFormat.java
+++ b/hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoop/mapreduce/AccumuloOutputFormat.java
@@ -16,8 +16,6 @@
*/
package org.apache.accumulo.hadoop.mapreduce;
-import static org.apache.accumulo.hadoopImpl.mapreduce.AbstractInputFormat.getClientInfo;
-
import java.io.IOException;
import org.apache.accumulo.core.client.Accumulo;
@@ -57,7 +55,7 @@ public class AccumuloOutputFormat extends OutputFormat<Text,Mutation> {
@Override
public void checkOutputSpecs(JobContext job) throws IOException {
- ClientInfo clientInfo = getClientInfo(job);
+ ClientInfo clientInfo = AccumuloOutputFormatImpl.getClientInfo(job);
String principal = clientInfo.getPrincipal();
AuthenticationToken token = clientInfo.getAuthenticationToken();
try (AccumuloClient c = Accumulo.newClient().from(clientInfo.getProperties()).build()) {
diff --git a/hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoopImpl/mapreduce/AccumuloOutputFormatImpl.java b/hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoopImpl/mapreduce/AccumuloOutputFormatImpl.java
index c1aa333..8750d74 100644
--- a/hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoopImpl/mapreduce/AccumuloOutputFormatImpl.java
+++ b/hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoopImpl/mapreduce/AccumuloOutputFormatImpl.java
@@ -88,7 +88,7 @@ public class AccumuloOutputFormatImpl {
*
* @since 2.0.0
*/
- protected static ClientInfo getClientInfo(JobContext context) {
+ public static ClientInfo getClientInfo(JobContext context) {
return OutputConfigurator.getClientInfo(CLASS, context.getConfiguration());
}
diff --git a/minicluster/src/main/java/org/apache/accumulo/cluster/standalone/StandaloneClusterControl.java b/minicluster/src/main/java/org/apache/accumulo/cluster/standalone/StandaloneClusterControl.java
index 13c33f7..8c43f6c 100644
--- a/minicluster/src/main/java/org/apache/accumulo/cluster/standalone/StandaloneClusterControl.java
+++ b/minicluster/src/main/java/org/apache/accumulo/cluster/standalone/StandaloneClusterControl.java
@@ -23,8 +23,6 @@ import java.io.BufferedReader;
import java.io.File;
import java.io.FileReader;
import java.io.IOException;
-import java.net.URL;
-import java.security.CodeSource;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;