[GitHub] [incubator-dubbo] haiyang1985 opened pull request #2582: applicationmodel provider & consumer serviceName is not unique

["haiyang1985 (GitHub)" <gi...@apache.org>]

## What is the purpose of the change
For below two situations, the provider & consumer cache in ApplicationModel is not unique. 

1. create two ReferenceConfig for same service with different configuration.
<dubbo:reference id="demoService" interface="com.alibaba.dubbo.DemoService">
</dubbo:reference>
<dubbo:reference id="demoServiceAsync" interface="com.alibaba.dubbo.DemoService" async="true">
</dubbo:reference>
2. create two ServiceConfig for same service with different implementation.
<bean id="demoService" class="com.alibaba.dubbo.DemoServiceImpl"/>
<dubbo:service interface="com.alibaba.dubbo.DemoService" ref="demoService">
</dubbo:service>
<bean id="demoService2" class="com.alibaba.dubbo.DemoServiceImpl2"/>
<dubbo:service interface="com.alibaba.dubbo.DemoService" ref="demoService2">
</dubbo:service>

## Brief changelog

Currently, dubbo uses interface+group+version for the cache unique serviceName. To support above two scenario, we are going to add hashCode for the unique serviceName.

## Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2582 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] diecui1202 closed pull request #2582: applicationmodel provider & consumer serviceName is not unique

["diecui1202 (GitHub)" <gi...@apache.org>]

[ pull request closed by diecui1202 ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2582 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org