You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by jihoonson <gi...@git.apache.org> on 2016/04/20 07:56:27 UTC
[GitHub] tajo pull request: TAJO-2123: Print parameters for parameterized t...
GitHub user jihoonson opened a pull request:
https://github.com/apache/tajo/pull/1004
TAJO-2123: Print parameters for parameterized tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jihoonson/tajo-2 TAJO-2123
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/1004.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1004
----
commit 4068b46ba6a5882b50320229b521bcbf076c7ff0
Author: Jihoon Son <ji...@apache.org>
Date: 2016-04-20T05:55:47Z
TAJO-2123
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2123: Print parameters for parameterized t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/1004
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2123: Print parameters for parameterized t...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/1004#discussion_r60524441
--- Diff: tajo-common/src/test/java/org/apache/tajo/datum/TestArithmeticOperator.java ---
@@ -40,7 +40,7 @@ public TestArithmeticOperator(String option) {
this.option = option;
}
- @Parameters
--- End diff --
Ok. Could you add this requirements to this page?
https://cwiki.apache.org/confluence/display/TAJO/Unit+Tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2123: Print parameters for parameterized t...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/1004#discussion_r60483477
--- Diff: tajo-common/src/test/java/org/apache/tajo/datum/TestArithmeticOperator.java ---
@@ -40,7 +40,7 @@ public TestArithmeticOperator(String option) {
this.option = option;
}
- @Parameters
--- End diff --
Should we add these arguments to all parameterized tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2123: Print parameters for parameterized t...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/1004#discussion_r60515305
--- Diff: tajo-common/src/test/java/org/apache/tajo/datum/TestArithmeticOperator.java ---
@@ -40,7 +40,7 @@ public TestArithmeticOperator(String option) {
this.option = option;
}
- @Parameters
--- End diff --
Yes, I can't see a better way now. Please refer to https://github.com/junit-team/junit4/wiki/Parameterized-tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2123: Print parameters for parameterized t...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/1004#issuecomment-212783090
Thanks. I added a page https://cwiki.apache.org/confluence/display/TAJO/How+to+Write+Unit+Tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2123: Print parameters for parameterized t...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/1004#issuecomment-212732800
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---