You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by "Valentyn Tymofieiev (JIRA)" <ji...@apache.org> on 2018/08/03 18:07:01 UTC

[jira] [Commented] (BEAM-5069) Incorrect string type check in _OutputProcessor.process_outputs.

    [ https://issues.apache.org/jira/browse/BEAM-5069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568553#comment-16568553 ] 

Valentyn Tymofieiev commented on BEAM-5069:
-------------------------------------------

CC: [~pabloem] [~matthiasml6] [~charleschen]

> Incorrect string type check in _OutputProcessor.process_outputs.
> ----------------------------------------------------------------
>
>                 Key: BEAM-5069
>                 URL: https://issues.apache.org/jira/browse/BEAM-5069
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>    Affects Versions: 2.6.0
>            Reporter: Valentyn Tymofieiev
>            Assignee: Valentyn Tymofieiev
>            Priority: Blocker
>
> Due to _# cython: language_level=3_ directive in [common.py|https://github.com/apache/beam/blob/8f1d86ea7bd5b118bc7e638d4d484445101526a1/sdks/python/apache_beam/runners/common.py#L18], the type check in [common.py|https://github.com/apache/beam/blob/8f1d86ea7bd5b118bc7e638d4d484445101526a1/sdks/python/apache_beam/runners/common.py#L729] does not recognize Python 2 strings, which have type 'bytes'.
> This causes pipelines to crash when this codepath is executed in Cythonized version of the SDK.
> The regression happened during ongoing efforts to make Beam codebase Python 3 compatible.
> The fix will need to be cherry-picked into the 2.6.0 release.
> Working on the fix.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)