You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/01/31 21:49:03 UTC
[GitHub] [incubator-yunikorn-k8shim] yangwwei opened a new pull request #225: [YUNIKORN-531] migrate to github action
yangwwei opened a new pull request #225:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/225
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on a change in pull request #225: [YUNIKORN-531] migrate to github action
Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #225:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/225#discussion_r568249094
##########
File path: .travis.yml
##########
@@ -37,36 +37,11 @@ install: true
jobs:
include:
- - stage: pre-commit checks
- script:
- - curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.33.0
- - make license-check
- - make test
- - make lint
- after_success: bash <(curl -s https://codecov.io/bash)
- stage: publish docker image
deploy:
provider: script
script: make push
on:
branch: master
condition: $TRAVIS_EVENT_TYPE = cron
Review comment:
I think we can safely remove it, even for the e2e test today, we do the build from scratch.
Let me remove this, we can revisit if we need to have auto-push in the feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s closed pull request #225: [YUNIKORN-531] migrate to github action
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #225:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/225
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #225: [YUNIKORN-531] migrate to github action
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #225:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/225#issuecomment-771416729
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/225?src=pr&el=h1) Report
> Merging [#225](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/225?src=pr&el=desc) (957c49b) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/225?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #225 +/- ##
=======================================
Coverage 59.75% 59.75%
=======================================
Files 35 35
Lines 3133 3133
=======================================
Hits 1872 1872
Misses 1180 1180
Partials 81 81
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/225?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/225?src=pr&el=footer). Last update [c47ed51...957c49b](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/225?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #225: [YUNIKORN-531] migrate to github action
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #225:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/225#discussion_r567599441
##########
File path: .travis.yml
##########
@@ -37,36 +37,11 @@ install: true
jobs:
include:
- - stage: pre-commit checks
- script:
- - curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.33.0
- - make license-check
- - make test
- - make lint
- after_success: bash <(curl -s https://codecov.io/bash)
- stage: publish docker image
deploy:
provider: script
script: make push
on:
branch: master
condition: $TRAVIS_EVENT_TYPE = cron
Review comment:
This needs to be replaced with a scheduled github action or something like it. We do need to be careful as this is one part of the [distribution guidelines](https://incubator.apache.org/guides/distribution.html#docker) which we are breaking:
```
on:
schedule:
- cron: '0 0 * * *'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on a change in pull request #225: [YUNIKORN-531] migrate to github action
Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #225:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/225#discussion_r568249094
##########
File path: .travis.yml
##########
@@ -37,36 +37,11 @@ install: true
jobs:
include:
- - stage: pre-commit checks
- script:
- - curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.33.0
- - make license-check
- - make test
- - make lint
- after_success: bash <(curl -s https://codecov.io/bash)
- stage: publish docker image
deploy:
provider: script
script: make push
on:
branch: master
condition: $TRAVIS_EVENT_TYPE = cron
Review comment:
I think we can safely remove it, even for the e2e test today, we do the build from scratch.
Let me remove this, we can revisit if we need to have auto-push in the feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #225: [YUNIKORN-531] migrate to github action
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #225:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/225#discussion_r568235869
##########
File path: .travis.yml
##########
@@ -37,36 +37,11 @@ install: true
jobs:
include:
- - stage: pre-commit checks
- script:
- - curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.33.0
- - make license-check
- - make test
- - make lint
- after_success: bash <(curl -s https://codecov.io/bash)
- stage: publish docker image
deploy:
provider: script
script: make push
on:
branch: master
condition: $TRAVIS_EVENT_TYPE = cron
Review comment:
The fact that we push the image means we break the distribution guidelines. The latest tag is pointing to unreleased code which based on the distribution guidelines point 6 we cannot do. We do not rely on the image for testing or other release work should we not turn it off until we have the solution worked out that complies with the distribution guidelines?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #225: [YUNIKORN-531] migrate to github action
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #225:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/225#issuecomment-771414494
The UT `TestValidateConfigMapWrongRequest` failure was because the error contains different messages on the box used to run github action (ubuntu). "Temp failure in name resolution" vs "no such host", Fixing it by simply verify the error is not nil, instead of detail messages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s closed pull request #225: [YUNIKORN-531] migrate to github action
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #225:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/225
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on a change in pull request #225: [YUNIKORN-531] migrate to github action
Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #225:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/225#discussion_r567602011
##########
File path: .travis.yml
##########
@@ -37,36 +37,11 @@ install: true
jobs:
include:
- - stage: pre-commit checks
- script:
- - curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.33.0
- - make license-check
- - make test
- - make lint
- after_success: bash <(curl -s https://codecov.io/bash)
- stage: publish docker image
deploy:
provider: script
script: make push
on:
branch: master
condition: $TRAVIS_EVENT_TYPE = cron
Review comment:
I leave this as an open item for now, let the Travis job push the docker images until we figure out how to do that with github action. I think I've tried to do this github action before, but I met some token issue unsolved. That was a few months ago, we probably need to fix this in a second step.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #225: [YUNIKORN-531] migrate to github action
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #225:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/225#issuecomment-771416729
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/225?src=pr&el=h1) Report
> Merging [#225](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/225?src=pr&el=desc) (957c49b) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/225?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #225 +/- ##
=======================================
Coverage 59.75% 59.75%
=======================================
Files 35 35
Lines 3133 3133
=======================================
Hits 1872 1872
Misses 1180 1180
Partials 81 81
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/225?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/225?src=pr&el=footer). Last update [c47ed51...957c49b](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/225?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #225: [YUNIKORN-531] migrate to github action
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #225:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/225#discussion_r568235869
##########
File path: .travis.yml
##########
@@ -37,36 +37,11 @@ install: true
jobs:
include:
- - stage: pre-commit checks
- script:
- - curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.33.0
- - make license-check
- - make test
- - make lint
- after_success: bash <(curl -s https://codecov.io/bash)
- stage: publish docker image
deploy:
provider: script
script: make push
on:
branch: master
condition: $TRAVIS_EVENT_TYPE = cron
Review comment:
The fact that we push the image means we break the distribution guidelines. The latest tag is pointing to unreleased code which based on the distribution guidelines point 6 we cannot do. We do not rely on the image for testing or other release work should we not turn it off until we have the solution worked out that complies with the distribution guidelines?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #225: [YUNIKORN-531] migrate to github action
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #225:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/225#issuecomment-771414494
The UT `TestValidateConfigMapWrongRequest` failure was because the error contains different messages on the box used to run github action (ubuntu). "Temp failure in name resolution" vs "no such host", Fixing it by simply verify the error is not nil, instead of detail messages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org