[GitHub] [incubator-hudi] ramachandranms commented on a change in pull request #1473: [HUDI-568] Improve unit test coverage

[GitBox <gi...@apache.org>]

ramachandranms commented on a change in pull request #1473: [HUDI-568] Improve unit test coverage
URL: https://github.com/apache/incubator-hudi/pull/1473#discussion_r402445412
 
 

 ##########
 File path: hudi-common/src/main/java/org/apache/hudi/common/util/collection/RocksDBDAO.java
 ##########
 @@ -75,9 +75,6 @@ public RocksDBDAO(String basePath, String rocksDBBasePath) {
    * Create RocksDB if not initialized.
    */
   private RocksDB getRocksDB() {
-    if (null == rocksDB) {
 
 Review comment:
   i looked at the entire code. it seems like `init()`  gets called from the only constructor in this class. so there will never be a case where `rocksDB == null`. this code seemed redundant and was never going to get called. that's why removed it. without this code, we are just going to return the `rocksDB` instance everytime without checking. Also checked the code and there is no where the variable is being set to null

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services