You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan Sperling <st...@elego.de> on 2012/12/17 14:51:52 UTC
Re: svn commit: r1422893 - in /subversion/trunk/subversion:
libsvn_subr/opt.c tests/cmdline/getopt_tests.py
On Mon, Dec 17, 2012 at 12:17:40PM -0000, brane@apache.org wrote:
> Author: brane
> Date: Mon Dec 17 12:17:40 2012
> New Revision: 1422893
>
> URL: http://svn.apache.org/viewvc?rev=1422893&view=rev
> Log:
> Don't colourize the plaintext-store warning,
> and don't ignore too many blank lines in the svn --version tests.
>
> * subversion/libsvn_subr/opt.c (svn_opt__print_version_info):
> Remove colour escapes. Add fixme comment about the meaning
> of the configuration flag.
Since the isatty() call was removed you could also remove the unistd.h
include now.
Re: svn commit: r1422893 - in /subversion/trunk/subversion: libsvn_subr/opt.c
tests/cmdline/getopt_tests.py
Posted by Branko Čibej <br...@wandisco.com>.
On 17.12.2012 14:51, Stefan Sperling wrote:
> On Mon, Dec 17, 2012 at 12:17:40PM -0000, brane@apache.org wrote:
>> Author: brane
>> Date: Mon Dec 17 12:17:40 2012
>> New Revision: 1422893
>>
>> URL: http://svn.apache.org/viewvc?rev=1422893&view=rev
>> Log:
>> Don't colourize the plaintext-store warning,
>> and don't ignore too many blank lines in the svn --version tests.
>>
>> * subversion/libsvn_subr/opt.c (svn_opt__print_version_info):
>> Remove colour escapes. Add fixme comment about the meaning
>> of the configuration flag.
> Since the isatty() call was removed you could also remove the unistd.h
> include now.
Eh. The morale of the story is, never commit when you're in a hurry.
Thanks for catching that!
-- Brane
--
Branko Čibej
Director of Subversion | WANdisco | www.wandisco.com