You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/02/20 10:43:18 UTC

[GitHub] [activemq-artemis] spyrkob commented on issue #2432: [ARTEMIS-2176] RA connection properties are not propagated to XARecov…

spyrkob commented on issue #2432: [ARTEMIS-2176] RA connection properties are not propagated to XARecov…
URL: https://github.com/apache/activemq-artemis/pull/2432#issuecomment-588939265
 
 
   @gaohoward I think it looks good, but I'm not that familiar with Artemis :) My only comment would be whether the ServerLocatorConfig#copyFrom could be a constructor instead of copy method - I think it would be more readable.
   
   Should I merge your commit in and update this PR or is it easier if you open a new PR to replace this one?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services