[GitHub] [hbase] sandeepvinayak commented on a change in pull request #2389: HBASE-24974: Provide a flexibility to print only row key and filter for multiple tables in the WALPrettyPrinter

[GitBox <gi...@apache.org>]

sandeepvinayak commented on a change in pull request #2389:
URL: https://github.com/apache/hbase/pull/2389#discussion_r487441981



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java
##########
@@ -223,6 +218,22 @@ public void setRowFilter(String row) {
     this.row = row;
   }
 
+  /**
+   * Option to print the row key only in case you just need the row keys from the WAL
+   */
+  public void setOutputOnlyRowKey() {
+    this.outputOnlyRowKey = true;
+  }
+
+  /**
+   * sets the position to start seeking the WAL file
+   * @param position
+   *          initial position to start seeking the given WAL file
+   */
+  public void setPosition(long position) {

Review comment:
       @bharathv I didn't add this method or position as part of this commit, it is already there at the end, I just added a java doc and repositioned it just like the master. Do you still want to have it as a separate commit?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org