You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by garrensmith <gi...@git.apache.org> on 2014/08/13 15:57:45 UTC
[GitHub] couchdb-fauxton pull request: Sidebar fixes
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/31
Sidebar fixes
A punch of fixes for the new sidebar.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/garrensmith/couchdb-fauxton sidebar-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/31.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #31
----
commit 337e9e4b54bfb4b4913a3ee831ff7e6868d577bc
Author: Garren Smith <ga...@gmail.com>
Date: 2014-08-13T09:54:07Z
Fix changes api-url
commit dac68f95700c6f89f94b699a6992f42601ff6003
Author: Garren Smith <ga...@gmail.com>
Date: 2014-08-13T10:33:15Z
Reword add options and add extension for all docs and design
commit 8c52515d4caf80009056895c03f738b1b902d9b8
Author: Garren Smith <ga...@gmail.com>
Date: 2014-08-13T10:57:14Z
improve design doc query for sidebar
commit 69e2945890fecbe00a272f80d14a65a22c8f0c27
Author: Garren Smith <ga...@gmail.com>
Date: 2014-08-13T12:42:22Z
Improve sidebar list of index types
commit 3dcf3e34e5fc6f73e4960ef19894fbaec5702157
Author: Garren Smith <ga...@gmail.com>
Date: 2014-08-13T12:46:30Z
Fix sidebar issue in Firefox
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Sidebar fixes
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/31#issuecomment-53394787
This is merged. Closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Sidebar fixes
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/31#issuecomment-52611135
@robertkowalski that wasn't meant to be there. I've removed it and I'm going pretend it wasn't ever there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Sidebar fixes
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/31#issuecomment-52471584
thanks @robertkowalski for the review. I've made the fixes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Sidebar fixes
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/31#issuecomment-52666021
+1 merge it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Sidebar fixes
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/31
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Sidebar fixes
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/31#issuecomment-52232777
This looks good, and it's really cool that you added tests :)
I found two small things, the main thing is that it seems that my view is not filtered for design docs when I click on "All Design docs".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Sidebar fixes
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/31#issuecomment-52330830
thanks for testing @robertkowalski. I'll fix that issue next week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---