[GitHub] [hadoop-ozone] bshashikant commented on a change in pull request #734: HDDS-3240. Improve write efficiency by creating container in parallel

[GitBox <gi...@apache.org>]

bshashikant commented on a change in pull request #734: HDDS-3240. Improve write efficiency by creating container in parallel
URL: https://github.com/apache/hadoop-ozone/pull/734#discussion_r400661933
 
 

 ##########
 File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java
 ##########
 @@ -664,12 +689,12 @@ private ByteString getCachedStateMachineData(Long logIndex, long term,
             future.complete(
                 getCachedStateMachineData(entry.getIndex(), entry.getTerm(),
                     requestProto));
-          } catch (IOException e) {
+          } catch (Exception e) {
             metrics.incNumReadStateMachineFails();
             future.completeExceptionally(e);
           }
           return future;
-        }, getChunkExecutor(requestProto.getWriteChunk()));
+        }, getReadChunkExecutor(requestProto.getWriteChunk()));
 
 Review comment:
   I think, lookUp from the cache can be done in the same thread where readStateMachineData is called. I don't think there is a need here to delegate the cache lookup to a different thread. Reading and writing from the disk can be done using the same set of chunk executor threads.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org