[GitHub] [spark] amaliujia commented on a diff in pull request #38604: [SPARK-41102][CONNECT] Merge SparkConnectPlanner and SparkConnectCommandPlanner

[GitBox <gi...@apache.org>]

amaliujia commented on code in PR #38604:
URL: https://github.com/apache/spark/pull/38604#discussion_r1019820702


##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectStreamHandler.scala:
##########
@@ -50,9 +49,9 @@ class SparkConnectStreamHandler(responseObserver: StreamObserver[Response]) exte
 
   def handlePlan(session: SparkSession, request: proto.Request): Unit = {

Review Comment:
   It is because we have divided it at the proto level: in proto, query and command are different.
   
   The primary reason for dividing is, query runs and return rows. Command apply a state change without return anything (except exceptions probably).
   
   Maybe there is better way to mode all of these. For example, will Catalog API fit into this model? I am still thinking about it but do not have a clear answer now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org