You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/07 17:30:39 UTC
[GitHub] kisimple opened a new pull request #7425:
[FLINK-9457][ResourceManager][YARN] Cancel container requests when
canceling pending slot allocations
kisimple opened a new pull request #7425: [FLINK-9457][ResourceManager][YARN] Cancel container requests when canceling pending slot allocations
URL: https://github.com/apache/flink/pull/7425
## What is the purpose of the change
This PR cancels container requests when canceling pending slot allocations for `YarnResourceManager`. `MesosResourceManager` could be updated by a separate PR.
## Brief changelog
- Add `cancelResourceRequest` to `SlotManager`. When canceling a pending slot request which no container had been assigned to and has a pending slot, cancel the container request via `cancelResourceRequest`.
- Add `cancelResourceRequest` to `ResourceAction`.
- Add `cancelWorkerRequest` to `ResourceManager`.
- Implement `cancelWorkerRequest` for `YarnResourceManager` to remove container request. When starting a new worker, save container request to `pendingContainerRequests` and try to find a matching pending request when canceling. Once the container was allocated, a matching pending request should be removed.
## Verifying this change
This change added tests:
- Add `testCancelResourceRequest` to `SlotManagerTest`.
- Add `testCancelWorkerRequest` to `YarnResourceManagerTest`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (**no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**no**)
- The serializers: (**no**)
- The runtime per-record code paths (performance sensitive): (**no**)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes**)
- The S3 file system connector: (**no**)
## Documentation
- Does this pull request introduce a new feature? (**no**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services