You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2021/12/20 15:12:35 UTC

[GitHub] [daffodil-vscode] mbeckerle commented on a change in pull request #63: Daffodil Debugger Classpaths

mbeckerle commented on a change in pull request #63:
URL: https://github.com/apache/daffodil-vscode/pull/63#discussion_r772442939



##########
File path: server/core/src/templates/bash-template
##########
@@ -263,8 +263,8 @@ run() {
     java_opts="${JAVA_OPTS}"
   fi
 
-  if [[ "$DAFFODIL_DEBUG_CLASSPATH" != "" ]]; then
-    app_classpath="$app_classpath:$DAFFODIL_DEBUG_CLASSPATH"
+  if [[ "$daffodilDebugClasspath" != "" ]]; then

Review comment:
       We don't have any actual style guidelines for this sort of thing. (Probably we should.)
   
   The precedent we do have is that the CLI looks for DAFFODIL_CLASSPATH, and it is a documented feature. So perhaps we should stick with that convention, and revert this change?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org