You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/05 12:26:46 UTC

[GitHub] [skywalking-java] wu-sheng commented on pull request #19: Add support for extClassLoader

wu-sheng commented on pull request #19:
URL: https://github.com/apache/skywalking-java/pull/19#issuecomment-913145477


   > Does this meet expectations?
   
   Yes, it is.
   
   > In addition,since I am using Windows os,I run this case in my IDEA instead of using run.sh scirpt.I'm going to try it on someone else's computer tomorrow
   
   You should modify `plugins-test.x.yaml` in https://github.com/apache/skywalking-java/tree/main/.github/workflows to make your test scenario running. 
   
   ___
   
   One important thing, you should not run tests based on jars in the `extlibs` folder. All jar files must be imported by maven in the package phase. Try to adjust the assembly.xml.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org