You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eventmesh.apache.org by "Alonexc (via GitHub)" <gi...@apache.org> on 2023/04/13 08:39:34 UTC

[GitHub] [eventmesh] Alonexc opened a new issue, #3723: [Enhancement] Not annotated parameter overrides @ParametersAreNonnullByDefault parameter[RabbitmqCloudEventWriter]

Alonexc opened a new issue, #3723:
URL: https://github.com/apache/eventmesh/issues/3723

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Enhancement Request
   
   ![image](https://user-images.githubusercontent.com/91315508/231702373-cfdc19b3-59d2-4a15-a9ac-c547d4c3ec59.png)
   ![image](https://user-images.githubusercontent.com/91315508/231702396-58ca0236-aeae-423a-a391-6928fbdbcad6.png)
   located at:
   eventmesh-storage-plugin/eventmesh-storage-rabbitmq/src/main/java/org/apache/eventmesh/storage/rabbitmq/cloudevent/RabbitmqCloudEventWriter.java line 40,58
   
   
   ### Describe the solution you'd like
   
   add @Nullable
   ![image](https://user-images.githubusercontent.com/91315508/231702501-8674be81-1d96-4a88-b7b4-f713081909c1.png)
   ![image](https://user-images.githubusercontent.com/91315508/231702502-bf4f60fe-9f4a-42d5-98bb-93ba97cd6c4e.png)
   
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] pandaapo commented on issue #3723: [Enhancement] Not annotated parameter overrides @ParametersAreNonnullByDefault parameter[RabbitmqCloudEventWriter]

Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on issue #3723:
URL: https://github.com/apache/eventmesh/issues/3723#issuecomment-1514760253

   In the method `withContextAttribute(String name, String value)`, two params will be applied to k-v in a `Map`. Can I add @Nonnull to these param instead of @Nullable?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] weihubeats closed issue #3723: [Enhancement] Not annotated parameter overrides @ParametersAreNonnullByDefault parameter[RabbitmqCloudEventWriter]

Posted by "weihubeats (via GitHub)" <gi...@apache.org>.
weihubeats closed issue #3723: [Enhancement] Not annotated parameter overrides @ParametersAreNonnullByDefault parameter[RabbitmqCloudEventWriter]
URL: https://github.com/apache/eventmesh/issues/3723


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] Alonexc commented on issue #3723: [Enhancement] Not annotated parameter overrides @ParametersAreNonnullByDefault parameter[RabbitmqCloudEventWriter]

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on issue #3723:
URL: https://github.com/apache/eventmesh/issues/3723#issuecomment-1515602844

   @pandaapo Yes, it was my mistake.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org