You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/07/30 19:48:52 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4337: Take
OFFLINE segment into account for real-time rebalancer
codecov-io edited a comment on issue #4337: Take OFFLINE segment into account for real-time rebalancer
URL: https://github.com/apache/incubator-pinot/pull/4337#issuecomment-503403448
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4337?src=pr&el=h1) Report
> Merging [#4337](https://codecov.io/gh/apache/incubator-pinot/pull/4337?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/08be56ebc34533e3a8810da737b60f7d91d2ec81?src=pr&el=desc) will **increase** coverage by `21.02%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4337?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4337 +/- ##
=============================================
+ Coverage 44.57% 65.59% +21.02%
- Complexity 0 20 +20
=============================================
Files 1062 1062
Lines 55160 55171 +11
Branches 8023 8024 +1
=============================================
+ Hits 24586 36192 +11606
+ Misses 28463 16362 -12101
- Partials 2111 2617 +506
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4337?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...RealtimeReplicaGroupSegmentAssignmentStrategy.java](https://codecov.io/gh/apache/incubator-pinot/pull/4337/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvc2VnbWVudC9SZWFsdGltZVJlcGxpY2FHcm91cFNlZ21lbnRBc3NpZ25tZW50U3RyYXRlZ3kuamF2YQ==) | `98.18% <100%> (+98.18%)` | `0 <0> (ø)` | :arrow_down: |
| [...ore/assignment/segment/SegmentAssignmentUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4337/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvc2VnbWVudC9TZWdtZW50QXNzaWdubWVudFV0aWxzLmphdmE=) | `96.63% <100%> (+96.63%)` | `0 <0> (ø)` | :arrow_down: |
| [...t/RealtimeBalanceNumSegmentAssignmentStrategy.java](https://codecov.io/gh/apache/incubator-pinot/pull/4337/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvc2VnbWVudC9SZWFsdGltZUJhbGFuY2VOdW1TZWdtZW50QXNzaWdubWVudFN0cmF0ZWd5LmphdmE=) | `100% <100%> (+100%)` | `0 <0> (ø)` | :arrow_down: |
| [...impl/dictionary/FloatOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4337/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPZmZIZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `83.92% <0%> (-5.36%)` | `0% <0%> (ø)` | |
| [...org/apache/pinot/client/DynamicBrokerSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/4337/diff?src=pr&el=tree#diff-cGlub3QtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jbGllbnQvRHluYW1pY0Jyb2tlclNlbGVjdG9yLmphdmE=) | `69.69% <0%> (-3.04%)` | `0% <0%> (ø)` | |
| [...der/HighLevelConsumerBasedRoutingTableBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4337/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9idWlsZGVyL0hpZ2hMZXZlbENvbnN1bWVyQmFzZWRSb3V0aW5nVGFibGVCdWlsZGVyLmphdmE=) | `90.9% <0%> (-3.04%)` | `0% <0%> (ø)` | |
| [...n/src/main/java/org/apache/pinot/common/Utils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4337/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vVXRpbHMuamF2YQ==) | `59.57% <0%> (-2.13%)` | `0% <0%> (ø)` | |
| [...r/helix/SegmentOnlineOfflineStateModelFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4337/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9TZWdtZW50T25saW5lT2ZmbGluZVN0YXRlTW9kZWxGYWN0b3J5LmphdmE=) | `60.19% <0%> (-1.95%)` | `0% <0%> (ø)` | |
| [...core/operator/filter/ExpressionFilterOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4337/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvRXhwcmVzc2lvbkZpbHRlck9wZXJhdG9yLmphdmE=) | `66.44% <0%> (-0.66%)` | `0% <0%> (ø)` | |
| [.../broker/routing/HelixExternalViewBasedRouting.java](https://codecov.io/gh/apache/incubator-pinot/pull/4337/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9IZWxpeEV4dGVybmFsVmlld0Jhc2VkUm91dGluZy5qYXZh) | `91.53% <0%> (+0.31%)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [559 more](https://codecov.io/gh/apache/incubator-pinot/pull/4337/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4337?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4337?src=pr&el=footer). Last update [08be56e...004e4cf](https://codecov.io/gh/apache/incubator-pinot/pull/4337?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org