You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/29 09:27:51 UTC

[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #4530: Add rewrite SQL test for query with joining two qualified columns.

tristaZero opened a new pull request #4530: Add rewrite SQL test for query with joining two qualified columns.
URL: https://github.com/apache/incubator-shardingsphere/pull/4530
 
 
   Fixes #4529 .
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4530: Add rewrite SQL test for query with joining two qualified columns.

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4530: Add rewrite SQL test for query with joining two qualified columns.
URL: https://github.com/apache/incubator-shardingsphere/pull/4530
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4530: Add rewrite SQL test for query with joining two qualified columns.

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4530: Add rewrite SQL test for query with joining two qualified columns.
URL: https://github.com/apache/incubator-shardingsphere/pull/4530#issuecomment-592927397
 
 
   ## Pull Request Test Coverage Report for [Build 18](https://coveralls.io/builds/29044819)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.006%**) to **58.769%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29044819/badge)](https://coveralls.io/builds/29044819) |
   | :-- | --: |
   | Change from base [Build 953](https://coveralls.io/builds/29044789): |  0.006% |
   | Covered Lines: | 10555 |
   | Relevant Lines: | 17960 |
   
   ---
   ##### πŸ’›  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4530: Add rewrite SQL test for query with joining two qualified columns.

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4530: Add rewrite SQL test for query with joining two qualified columns.
URL: https://github.com/apache/incubator-shardingsphere/pull/4530#issuecomment-592929752
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4530?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@e9b2148`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4530/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4530?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #4530   +/-   ##
   =========================================
     Coverage          ?   55.17%           
     Complexity        ?      331           
   =========================================
     Files             ?      954           
     Lines             ?    17960           
     Branches          ?     3397           
   =========================================
     Hits              ?     9909           
     Misses            ?     7418           
     Partials          ?      633
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4530?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Ξ” = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4530?src=pr&el=footer). Last update [e9b2148...2b3322c](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4530: Add rewrite SQL test for query with joining two qualified columns.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4530: Add rewrite SQL test for query with joining two qualified columns.
URL: https://github.com/apache/incubator-shardingsphere/pull/4530#issuecomment-592927397
 
 
   ## Pull Request Test Coverage Report for [Build 9880](https://coveralls.io/builds/29044988)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **3** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.006%**) to **58.758%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29044988/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29044988/badge)](https://coveralls.io/builds/29044988) |
   | :-- | --: |
   | Change from base [Build 953](https://coveralls.io/builds/29044789): |  -0.006% |
   | Covered Lines: | 10553 |
   | Relevant Lines: | 17960 |
   
   ---
   ##### πŸ’›  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services