You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@gmail.com> on 2017/01/06 06:44:09 UTC

Review Request 55255: Added a test to check 'roles' is included in the `/state`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55255/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.


Bugs: MESOS-6855
    https://issues.apache.org/jira/browse/MESOS-6855


Repository: mesos


Description
-------

Added a test to check 'roles' is included in the `/state`.


Diffs
-----

  src/tests/master_tests.cpp 1cf4c92b2474e18771459f877b2f3c49077e8a01 

Diff: https://reviews.apache.org/r/55255/diff/


Testing
-------

make check

start a Mesos cluster and query `/state` to see 'roles' is included.


Thanks,

Jay Guo


Re: Review Request 55255: Added a test to check 'roles' is included in the `/state`.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55255/#review160708
-----------------------------------------------------------



Patch looks great!

Reviews applied: [55251, 55252, 55253, 55254, 55255]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 6, 2017, 6:44 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55255/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2017, 6:44 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.
> 
> 
> Bugs: MESOS-6855
>     https://issues.apache.org/jira/browse/MESOS-6855
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test to check 'roles' is included in the `/state`.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 1cf4c92b2474e18771459f877b2f3c49077e8a01 
> 
> Diff: https://reviews.apache.org/r/55255/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> start a Mesos cluster and query `/state` to see 'roles' is included.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Re: Review Request 55255: Added a test to check 'roles' is included in the `/state`.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55255/#review161711
-----------------------------------------------------------



Patch looks great!

Reviews applied: [55252, 55253, 55254, 55255]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos ReviewBot


On Jan. 16, 2017, 7:03 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55255/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2017, 7:03 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.
> 
> 
> Bugs: MESOS-6855
>     https://issues.apache.org/jira/browse/MESOS-6855
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test to check 'roles' is included in the `/state`.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp da7094dbbafbb0ab1153a0a4a6fcabd63888d67a 
> 
> Diff: https://reviews.apache.org/r/55255/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> start a Mesos cluster and query `/state` to see 'roles' is included.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Re: Review Request 55255: Added a test to check 'roles' is included in the `/state`.

Posted by Jay Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55255/
-----------------------------------------------------------

(Updated Jan. 16, 2017, 3:03 p.m.)


Review request for mesos, Anand Mazumdar, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.


Changes
-------

rebase


Bugs: MESOS-6855
    https://issues.apache.org/jira/browse/MESOS-6855


Repository: mesos


Description
-------

Added a test to check 'roles' is included in the `/state`.


Diffs (updated)
-----

  src/tests/master_tests.cpp da7094dbbafbb0ab1153a0a4a6fcabd63888d67a 

Diff: https://reviews.apache.org/r/55255/diff/


Testing
-------

make check

start a Mesos cluster and query `/state` to see 'roles' is included.


Thanks,

Jay Guo