You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Knut Anders Hatlen (Commented) (JIRA)" <ji...@apache.org> on 2011/10/28 11:00:33 UTC

[jira] [Commented] (DERBY-5486) Upgrade tests should verify that DERBY-4437 was backed out of 10.8.2.2

    [ https://issues.apache.org/jira/browse/DERBY-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138178#comment-13138178 ] 

Knut Anders Hatlen commented on DERBY-5486:
-------------------------------------------

Would it be better to move the test cases from Changes10_8_2 to Changes10_9? Since the changes didn't actually end up in 10.8.2, the current name of the class is misleading.
                
> Upgrade tests should verify that DERBY-4437 was backed out of 10.8.2.2
> ----------------------------------------------------------------------
>
>                 Key: DERBY-5486
>                 URL: https://issues.apache.org/jira/browse/DERBY-5486
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL, Test
>            Reporter: Rick Hillegas
>
> The following code in UpgradeRun needs to be reworked to verify that sequence/identities behave as expected when upgrading from 10.8.2.2:
>                 if ( lessThan( version, new int[] { 10, 8, 1, 6 } ) )
>                 { suite.addTest(Changes10_8_2.suite(phase)); }
> The following might do the trick:
>                 if (oldMinor < 7)
>                     suite.addTest(Changes10_7.suite(phase));
>                 if (oldMinor < 9)
>                 {
>                     suite.addTest(Changes10_9.suite(phase));
>                     suite.addTest(Changes10_8_2.suite(phase));
>                 }
> Thanks to Kristian for spotting this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira