You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/31 08:58:48 UTC
[GitHub] [apisix-dashboard] idbeta opened a new issue #1174: bug: when setting the plugin in codemirror, an error is prompted.
idbeta opened a new issue #1174:
URL: https://github.com/apache/apisix-dashboard/issues/1174
# Bug report
## Describe the bug
after setting the plugin in codemirror, when submit it, an error is prompted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1174: bug: when setting the plugin in codemirror, an error is prompted.
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1174:
URL: https://github.com/apache/apisix-dashboard/issues/1174#issuecomment-753733353
we only need to add some tips in the frontend, tells users just enable or disable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1174: bug: when setting the plugin in codemirror, an error is prompted.
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1174:
URL: https://github.com/apache/apisix-dashboard/issues/1174#issuecomment-754495350
ping
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #1174: bug: when setting the plugin in codemirror, an error is prompted.
Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #1174:
URL: https://github.com/apache/apisix-dashboard/issues/1174#issuecomment-753713711
@liuxiran @nic-chen Hello, please take a look at this issue. This issue happened due to a different schema for Route and Consumer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1174: bug: when setting the plugin in codemirror, an error is prompted.
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1174:
URL: https://github.com/apache/apisix-dashboard/issues/1174#issuecomment-754513502
fine, then for Route, Service, and GlobalRule, we only disable/enable auth plugins, right? 🤔
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1174: bug: when setting the plugin in codemirror, an error is prompted.
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1174:
URL: https://github.com/apache/apisix-dashboard/issues/1174#issuecomment-753718025
> the authentication plugins should be only shown with a switch to enabled/disabled in route or service module.
According to https://github.com/apache/apisix-dashboard/issues/529 .
I think we should not config the auth plugins in route, service or global rule.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1174: bug: when setting the plugin in codemirror, an error is prompted.
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #1174:
URL: https://github.com/apache/apisix-dashboard/issues/1174
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1174: bug: when setting the plugin in codemirror, an error is prompted.
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1174:
URL: https://github.com/apache/apisix-dashboard/issues/1174#issuecomment-753742515
> > > the authentication plugins should be only shown with a switch to enabled/disabled in route or service module.
> >
> >
> > According to #529 .
> > I think we should not config the auth plugins in route, service or global rule.
>
> Yep, only enable/disable auth plugins in `Route` `Service` module is engough ^_^
> but for the global rule, I'm not sure if we only enable a auth plugin, what will happen in Consumer module? @nic-chen
`global rule` acts like enable plugins for routes. So it's same as enable plugins in routes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1174: bug: when setting the plugin in codemirror, an error is prompted.
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1174:
URL: https://github.com/apache/apisix-dashboard/issues/1174#issuecomment-753713711
@liuxiran @nic-chen Hello, please take a look at this issue. This issue happened due to different schema for Route and Consumer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1174: bug: when setting the plugin in codemirror, an error is prompted.
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1174:
URL: https://github.com/apache/apisix-dashboard/issues/1174#issuecomment-753732243
> > the authentication plugins should be only shown with a switch to enabled/disabled in route or service module.
>
> According to #529 .
>
> I think we should not config the auth plugins in route, service or global rule.
then how to bind Consumer with Route?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran edited a comment on issue #1174: bug: when setting the plugin in codemirror, an error is prompted.
Posted by GitBox <gi...@apache.org>.
liuxiran edited a comment on issue #1174:
URL: https://github.com/apache/apisix-dashboard/issues/1174#issuecomment-753737818
> > the authentication plugins should be only shown with a switch to enabled/disabled in route or service module.
>
> According to #529 .
>
> I think we should not config the auth plugins in route, service or global rule.
Yep, only enable/disable auth plugins in `Route` `Service` module is engough ^_^
but for the global rule, I'm not sure if we only enable a auth plugin, what will happen in Consumer module? @nic-chen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1174: bug: when setting the plugin in codemirror, an error is prompted.
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1174:
URL: https://github.com/apache/apisix-dashboard/issues/1174#issuecomment-753747114
A little strange 🤔 If we need to create a global rule with auth plugins, we should:
1. Create a Consumer with Auth plugins;
2. Create a global rule and enable at least 1 auth plugin;
cc @membphis @spacewander May I know what's your opinion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta commented on issue #1174: bug: when setting the plugin in codemirror, an error is prompted.
Posted by GitBox <gi...@apache.org>.
idbeta commented on issue #1174:
URL: https://github.com/apache/apisix-dashboard/issues/1174#issuecomment-753728744
> > the authentication plugins should be only shown with a switch to enabled/disabled in route or service module.
>
> According to #529 .
>
> I think we should not config the auth plugins in route, service or global rule.
but the `Plugin List` page is not `global rule`, can’t enable `auth plugins` in it, will make others strange.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #1174: bug: when setting the plugin in codemirror, an error is prompted.
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #1174:
URL: https://github.com/apache/apisix-dashboard/issues/1174#issuecomment-753737818
> > the authentication plugins should be only shown with a switch to enabled/disabled in route or service module.
>
> According to #529 .
>
> I think we should not config the auth plugins in route, service or global rule.
Agree, only enable/disable auth plugins in `Route` `Service` module is engough ^_^
but for the global rule, I'm not sure is we only enable a auth plugin, what will happen in Consumer module?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1174: bug: when setting the plugin in codemirror, an error is prompted.
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1174:
URL: https://github.com/apache/apisix-dashboard/issues/1174#issuecomment-753733030
Got it, then for Route, Service and Global Rule, we only need to enable/disable Auth plugins without any configurations, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1174: bug: when setting the plugin in codemirror, an error is prompted.
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1174:
URL: https://github.com/apache/apisix-dashboard/issues/1174#issuecomment-754699463
> fine, then for Route, Service, and GlobalRule, we only disable/enable auth plugins, right? 🤔
yes, you are right. @juzhiyuan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] spacewander commented on issue #1174: bug: when setting the plugin in codemirror, an error is prompted.
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #1174:
URL: https://github.com/apache/apisix-dashboard/issues/1174#issuecomment-754508964
The auth plugin is all for selecting a consumer. It is a noop if we don't have any consumer. Also the route configuration for auth plugin is usually empty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org