[GitHub] [maven] tbw777 commented on a diff in pull request #984: Speedup by removing non pattern replaceAll with constant arg

["tbw777 (via GitHub)" <gi...@apache.org>]

tbw777 commented on code in PR #984:
URL: https://github.com/apache/maven/pull/984#discussion_r1099125397


##########
maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java:
##########
@@ -175,6 +175,8 @@ public class MavenCli {
 
     private CLIManager cliManager;
 
+    private static final Pattern NEXT_LINE = Pattern.compile("(\r\n)|(\r)|(\n)");

Review Comment:
   DOS & Windows: \r\n 0D0A (hex), 13,10 (decimal)
   Unix & Mac OS X: \n, 0A, 10
   Macintosh (OS 9): \r, 0D, 13
   
   so your pattern not applicable to OS 9 and similar



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org