[GitHub] [spark] srowen commented on a change in pull request #27546: [SPARK-30773][ML]Support NativeBlas for level-1 routines

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #27546: [SPARK-30773][ML]Support NativeBlas for level-1 routines
URL: https://github.com/apache/spark/pull/27546#discussion_r386429848
 
 

 ##########
 File path: mllib-local/pom.xml
 ##########
 @@ -61,13 +61,17 @@
       This spark-tags test-dep is needed even though it isn't used in this module, otherwise testing-cmds that exclude
       them will yield errors.
     -->
+    <dependency>
 
 Review comment:
   Ah, right. OK, in that case I would leave the property in `core`, but reference it only by name (unfortunately) here in `mllib-local`, with a comment about why. You can remove `.ml` from the name too; it's not specific to ML really.
   
   I don't think env variables are a good solution here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org