You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "Yan Fang (JIRA)" <ji...@apache.org> on 2014/07/20 09:35:38 UTC
[jira] [Updated] (SAMZA-349) MetricsSnapshotReporter does not
refresh metrics every 60 seconds
[ https://issues.apache.org/jira/browse/SAMZA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yan Fang updated SAMZA-349:
---------------------------
Attachment: SAMZA-349.patch
a quick fix by adding the counter.clear() in the code. No RB since it only contains 2 lines of code. Thank you.
> MetricsSnapshotReporter does not refresh metrics every 60 seconds
> -----------------------------------------------------------------
>
> Key: SAMZA-349
> URL: https://issues.apache.org/jira/browse/SAMZA-349
> Project: Samza
> Issue Type: Bug
> Reporter: Yan Fang
> Attachments: SAMZA-349.patch
>
>
> If my understanding is correct, the metrics we provide are for every 60 seconds and all counters will be reset every 60 seconds. Current the MetricsSnapshotReporter seems missing this implementation. It sends out the metrics every 60 seconds but does not reset the counter value.
> {code}
> registry.getGroup(group).foreach {
> case (name, metric) =>
> metric.visit(new MetricsVisitor {
> def counter(counter: Counter) = groupMsg.put(name, counter.getCount: java.lang.Long)
> def gauge[T](gauge: Gauge[T]) = groupMsg.put(name, gauge.getValue.asInstanceOf[Object])
> })
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)