You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/09/20 21:45:09 UTC
[kudu-CR] Add support for clang from XCode 8 in macOS
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4482
Change subject: Add support for clang from XCode 8 in macOS
......................................................................
Add support for clang from XCode 8 in macOS
Since upgrading XCode to 8 (even in El Capitan), cmake has outputted an
unsupported compiler message:
Unknown compiler. Version info:
Apple LLVM version 8.0.0 (clang-800.0.38)
Target: x86_64-apple-darwin16.0.0
Thread model: posix
InstalledDir:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
This is also the default version in the new macOS Sierra.
This patch fixes this by adding it to the list of supported
compilers.
Change-Id: I74574fb80525c7b7545e2aaf9b220f63486a46b6
---
M cmake_modules/CompilerInfo.cmake
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/4482/1
--
To view, visit http://gerrit.cloudera.org:8080/4482
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I74574fb80525c7b7545e2aaf9b220f63486a46b6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] Add support for clang from XCode 8 in macOS
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Add support for clang from XCode 8 in macOS
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4482
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74574fb80525c7b7545e2aaf9b220f63486a46b6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add support for clang from XCode 8 in macOS
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: Add support for clang from XCode 8 in macOS
......................................................................
Patch Set 1: -Code-Review
--
To view, visit http://gerrit.cloudera.org:8080/4482
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74574fb80525c7b7545e2aaf9b220f63486a46b6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add support for clang from XCode 8 in macOS
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.
Change subject: Add support for clang from XCode 8 in macOS
......................................................................
Add support for clang from XCode 8 in macOS
Since upgrading XCode to 8 (even in El Capitan), cmake has outputted an
unsupported compiler message:
Unknown compiler. Version info:
Apple LLVM version 8.0.0 (clang-800.0.38)
Target: x86_64-apple-darwin16.0.0
Thread model: posix
InstalledDir:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
This is also the default version in the new macOS Sierra.
This patch fixes this by adding it to the list of supported
compilers.
Note that this patch, by itself, won't allow to fully compile Kudu in
macOS Sierra, as the current version of tcmalloc is incompatible:
https://github.com/gperftools/gperftools/issues/827
We need to wait until the issue above is fixed in order to fully support
building with the default toolchain in macOS Sierra. In the meanwhile this
patch is still valuable. It's still possible to build Kudu with the clang
toolchain we ship and CLion users can still use the default toolchain,
as long as they don't actually run the CLion build's binaries.
Were we to change to jemalloc, that issue is solved there:
https://github.com/jemalloc/jemalloc/pull/427
Change-Id: I74574fb80525c7b7545e2aaf9b220f63486a46b6
Reviewed-on: http://gerrit.cloudera.org:8080/4482
Reviewed-by: Dan Burkert <da...@cloudera.com>
Tested-by: Kudu Jenkins
---
M cmake_modules/CompilerInfo.cmake
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4482
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74574fb80525c7b7545e2aaf9b220f63486a46b6
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Add support for clang from XCode 8 in macOS
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: Add support for clang from XCode 8 in macOS
......................................................................
Patch Set 1: Code-Review-1
Hum, turns out there's a malloc issue with the new compiler. Sorting that out first.
--
To view, visit http://gerrit.cloudera.org:8080/4482
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74574fb80525c7b7545e2aaf9b220f63486a46b6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add support for clang from XCode 8 in macOS
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Add support for clang from XCode 8 in macOS
......................................................................
Patch Set 2: Code-Review+2
I agree the malloc patch should be separate.
--
To view, visit http://gerrit.cloudera.org:8080/4482
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74574fb80525c7b7545e2aaf9b220f63486a46b6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add support for clang from XCode 8 in macOS
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: Add support for clang from XCode 8 in macOS
......................................................................
Patch Set 1:
It seems this is missing a gperftools side update to work with tcmalloc: https://github.com/gperftools/gperftools/issues/827
Interestingly this is working jemalloc, were we to change to it: https://github.com/jemalloc/jemalloc/pull/427
I suggest that we still merge this. I won't break previous versions and, though it won't fully work yet, it will at least allow to use CLion, while still building on a terminal.
--
To view, visit http://gerrit.cloudera.org:8080/4482
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74574fb80525c7b7545e2aaf9b220f63486a46b6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add support for clang from XCode 8 in macOS
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4482
to look at the new patch set (#2).
Change subject: Add support for clang from XCode 8 in macOS
......................................................................
Add support for clang from XCode 8 in macOS
Since upgrading XCode to 8 (even in El Capitan), cmake has outputted an
unsupported compiler message:
Unknown compiler. Version info:
Apple LLVM version 8.0.0 (clang-800.0.38)
Target: x86_64-apple-darwin16.0.0
Thread model: posix
InstalledDir:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
This is also the default version in the new macOS Sierra.
This patch fixes this by adding it to the list of supported
compilers.
Note that this patch, by itself, won't allow to fully compile Kudu in
macOS Sierra, as the current version of tcmalloc is incompatible:
https://github.com/gperftools/gperftools/issues/827
We need to wait until the issue above is fixed in order to fully support
building with the default toolchain in macOS Sierra. In the meanwhile this
patch is still valuable. It's still possible to build Kudu with the clang
toolchain we ship and CLion users can still use the default toolchain,
as long as they don't actually run the CLion build's binaries.
Were we to change to jemalloc, that issue is solved there:
https://github.com/jemalloc/jemalloc/pull/427
Change-Id: I74574fb80525c7b7545e2aaf9b220f63486a46b6
---
M cmake_modules/CompilerInfo.cmake
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/4482/2
--
To view, visit http://gerrit.cloudera.org:8080/4482
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I74574fb80525c7b7545e2aaf9b220f63486a46b6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins