You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@creadur.apache.org by GitBox <gi...@apache.org> on 2022/03/28 12:49:23 UTC
[GitHub] [creadur-rat] ottlinger opened a new pull request #57: RAT-273: Due to JDK changes test expectations had to be changed
ottlinger opened a new pull request #57:
URL: https://github.com/apache/creadur-rat/pull/57
LineNumberReader behaves differently in newer JDKs, thus test expectations read more lines as a line ending is treated differently than in JDK8.
see details in https://issues.apache.org/jira/browse/RAT-273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [creadur-rat] ottlinger commented on pull request #57: RequestForComments/Feedback - RAT-273: Due to JDK changes test expectations had to be changed when building against newer JDKs
Posted by GitBox <gi...@apache.org>.
ottlinger commented on pull request #57:
URL: https://github.com/apache/creadur-rat/pull/57#issuecomment-1080655320
@jochenw can you help out with the problems in RatCheckMojoTest? I experimented with adding argLine arguments to maven-surefire/failsafe plugin but am unable to get it running locally with JDK18. Maybe you know a workaround. Thanks
[patchForRatCheckMojoTest.txt](https://github.com/apache/creadur-rat/files/8363155/patchForRatCheckMojoTest.txt)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
RequestForReview/Comments on RAT-273: Due to JDK changes test expectations had to be changed / enabling RAT builds with more recent JDK
Posted by "P. Ottlinger" <po...@apache.org>.
Hi *,
when I tried to build RAT against newer JDKs I experienced test
failures. These were due to API changes inside JDK's LineNumberReader.
Newer JDKs treat a non-existing line ending as implicit line ending,
while JDK8 did not count these tokens.
Therefore I had to adapt the tests and would be happy to get some
feedback from you:
URL: https://github.com/apache/creadur-rat/pull/57
Cheers,
Phil
[GitHub] [creadur-rat] ottlinger commented on pull request #57: RequestForComments/Feedback - RAT-273: Due to JDK changes test expectations had to be changed when building against newer JDKs
Posted by GitBox <gi...@apache.org>.
ottlinger commented on pull request #57:
URL: https://github.com/apache/creadur-rat/pull/57#issuecomment-1081021794
@jochenw if you apply the attached patch to the branch you'll see the RatCheckMojoTest failures ..... with JDK17 and 18. Apart from that there seems to be a javadoc issue, but any help is greatly appreciated :
[patchShowingErrorWithJDK18or17.txt](https://github.com/apache/creadur-rat/files/8365484/patchShowingErrorWithJDK18or17.txt)
)
In the patch I tried to add argument parameters that should fix the error, but maybe you have a solution that is within the code itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [creadur-rat] jochenw commented on pull request #57: RequestForComments/Feedback - RAT-273: Due to JDK changes test expectations had to be changed when building against newer JDKs
Posted by GitBox <gi...@apache.org>.
jochenw commented on pull request #57:
URL: https://github.com/apache/creadur-rat/pull/57#issuecomment-1080990109
@ottlinger Glad to help, if you let me know, how to reproduce the issue. For now, I'll assume that I only need to use Java 17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org