You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Guanghao Zhang (Jira)" <ji...@apache.org> on 2020/07/01 01:01:11 UTC

[jira] [Commented] (HBASE-24624) Optimize table.jsp code

    [ https://issues.apache.org/jira/browse/HBASE-24624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149024#comment-17149024 ] 

Guanghao Zhang commented on HBASE-24624:
----------------------------------------

[~songxincun] Can you help to prepare a PR for branch-2. It conflict too much when cherry-pick to branch-2. Thanks.

> Optimize table.jsp code
> -----------------------
>
>                 Key: HBASE-24624
>                 URL: https://issues.apache.org/jira/browse/HBASE-24624
>             Project: HBase
>          Issue Type: Improvement
>          Components: UI
>    Affects Versions: 3.0.0-alpha-1
>            Reporter: song XinCun
>            Assignee: song XinCun
>            Priority: Minor
>
> # Rename buildRegionServerLink to buildRegionLink, for it returns the link of region, not regionserver.
>  # Add buildRegionDeployedServerTag and moreRegionsToRender, this two function can be used everywhere in table.jsp, and with them we can reduce a lot of same code.
>  # Fix bug which locality stats tab can not sort. This is because we set wrong id for locality stats tab.
>  # We use too much "if (withReplica)..." statements, remove it and let the page always show the replica id of regions. This can help to keep the code simple and the UI style union.
>  # When there is no primary region on regionserver, show 0 instead of null



--
This message was sent by Atlassian Jira
(v8.3.4#803005)