You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "maskit (via GitHub)" <gi...@apache.org> on 2023/09/01 20:35:19 UTC

[GitHub] [trafficserver] maskit opened a new issue, #10341: CID 1518597: Side effect in assertion

maskit opened a new issue, #10341:
URL: https://github.com/apache/trafficserver/issues/10341

   intercept.cc
   ```
   98  void
    99  write(TSVConn vc, TSCont contp)
   100  {
   101    TSReleaseAssert(this->vio == nullptr);
        	CID 1518611: Side effect in assertion (ASSERT_SIDE_EFFECT) [[select issue](https://scan6.scan.coverity.com/defectInstanceId=34751323&fileInstanceId=163647460&mergedDefectId=1518611)]
   102    TSReleaseAssert((this->iobuf = TSIOBufferCreate()));
      	
   CID 1518597 (#1 of 1): Side effect in assertion (ASSERT_SIDE_EFFECT)
   assignment_where_comparison_intended: Assignment this->reader = tsapi::c::TSIOBufferReaderAlloc(this->iobuf) has a side effect. This code will work differently in a non-debug build.
      	Did you intend to use a comparison (==) instead?
   103    TSReleaseAssert((this->reader = TSIOBufferReaderAlloc(this->iobuf)));
   104
   105    this->vio = TSVConnWrite(vc, contp, this->reader, INT64_MAX);
   106  }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] bryancall closed issue #10341: CID 1518597: Side effect in assertion

Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall closed issue #10341: CID 1518597: Side effect in assertion
URL: https://github.com/apache/trafficserver/issues/10341


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org