You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/05/02 01:20:09 UTC

[GitHub] [netbeans] EnricoScantamburlo opened a new pull request #2120: Added property to allow the user to specify the max number of objects and details in search:

EnricoScantamburlo opened a new pull request #2120:
URL: https://github.com/apache/netbeans/pull/2120


   Some clients of ours had this problem, they had a lot of files to search inside, but NetBeans limited the maximum number of results to 500.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi merged pull request #2120: Added property to allow the user to specify the max number of objects and details in search:

Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #2120:
URL: https://github.com/apache/netbeans/pull/2120


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2120: Added property to allow the user to specify the max number of objects and details in search:

Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2120:
URL: https://github.com/apache/netbeans/pull/2120#discussion_r487641496



##########
File path: platform/api.search/src/org/netbeans/modules/search/Constants.java
##########
@@ -29,11 +29,11 @@
     /**
      * maximum number of found objects
      */
-    public static final int COUNT_LIMIT = 500;
+    public static final int COUNT_LIMIT = Integer.getInteger("netbeans.search.count.limit", 500);
     /**
      * maximum total number of detail entries for found objects
      */
-    public static final int DETAILS_COUNT_LIMIT = 5000;
+    public static final int DETAILS_COUNT_LIMIT = Integer.getInteger("netbeans.search.details.count.limit", 5000);

Review comment:
       Dtto.

##########
File path: platform/api.search/src/org/netbeans/modules/search/Constants.java
##########
@@ -29,11 +29,11 @@
     /**
      * maximum number of found objects
      */
-    public static final int COUNT_LIMIT = 500;
+    public static final int COUNT_LIMIT = Integer.getInteger("netbeans.search.count.limit", 500);

Review comment:
       This shall be documented in `arch.xml` as an `<api group="systemproperty" ...>some description</api>`. See [howto](http://wiki.netbeans.org/APIDevelopment#Writing_the_documentation) for more details about `arch.xml`. 
   
   Also one shall version the change. E.g. increase the module version and leave a note in `apichanges.xml` file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists